From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EA7846F4B7 for ; Mon, 30 Aug 2021 10:30:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C84F01778A for ; Mon, 30 Aug 2021 10:30:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 01D4817780 for ; Mon, 30 Aug 2021 10:30:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C0ABF441D6 for ; Mon, 30 Aug 2021 10:30:10 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Mon, 30 Aug 2021 10:30:09 +0200 Message-Id: <20210830083009.1853983-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.466 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] ui: fix order of prune keep reasons X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 08:30:21 -0000 two things wrong with the old code: * the sort function wants -1, 0 and 1 as a return value for ab respectively, not a bool (which a < b returns) * we have to sort the newest backups first, since the first reason is 'keep-last'. until now, we sorted the oldest backup first, resulting in the older backups getting the 'keep-last' reason reported by a user in the forum: https://forum.proxmox.com/threads/prune-ui-and-prune-schedule-simulator-dont-match.94944/ Signed-off-by: Dominik Csapak --- www/datastore/Prune.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/datastore/Prune.js b/www/datastore/Prune.js index 3e74269f..42ea21bf 100644 --- a/www/datastore/Prune.js +++ b/www/datastore/Prune.js @@ -86,7 +86,7 @@ Ext.define('PBS.Datastore.PruneInputPanel', { let counter = {}; backups.sort(function(a, b) { - return a["backup-time"] < b["backup-time"]; + return b["backup-time"] - a["backup-time"]; }); let ruleIndex = -1; -- 2.30.2