From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D50F56DD81 for ; Thu, 19 Aug 2021 13:04:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B6DFB14CB1 for ; Thu, 19 Aug 2021 13:04:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7C5BE1444A for ; Thu, 19 Aug 2021 13:04:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 578BF43453 for ; Thu, 19 Aug 2021 13:04:03 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Thu, 19 Aug 2021 13:03:43 +0200 Message-Id: <20210819110343.8708-16-h.laimer@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210819110343.8708-1-h.laimer@proxmox.com> References: <20210819110343.8708-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.202 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 15/15] ui: add (un)mount button to summary X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2021 11:04:41 -0000 And only try to load datastore information if the datastore is available. --- www/datastore/Summary.js | 77 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 73 insertions(+), 4 deletions(-) diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js index 628f0c60..1c5f41d1 100644 --- a/www/datastore/Summary.js +++ b/www/datastore/Summary.js @@ -185,8 +185,6 @@ Ext.define('PBS.DataStoreSummary', { padding: 5, }, - tbar: ['->', { xtype: 'proxmoxRRDTypeSelector' }], - items: [ { xtype: 'container', @@ -257,7 +255,63 @@ Ext.define('PBS.DataStoreSummary', { model: 'pve-rrd-datastore', }); - me.callParent(); + me.statusStore = Ext.create('Proxmox.data.ObjectStore', { + url: `/api2/json/admin/datastore/${me.datastore}/status`, + interval: 1000, + }); + + let unmountBtn = Ext.create('Ext.Button', { + text: gettext('Unmount'), + hidden: true, + handler: () => { + Proxmox.Utils.API2Request({ + url: `/admin/datastore/${me.datastore}/unmount`, + method: 'POST', + failure: function(response) { + Ext.Msg.alert(gettext('Error'), response.htmlStatus); + }, + success: function(response, options) { + Ext.create('Proxmox.window.TaskViewer', { + upid: response.result.data, + }).show(); + }, + }); + }, + }); + + let mountBtn = Ext.create('Ext.Button', { + text: gettext('Mount'), + hidden: true, + handler: () => { + Proxmox.Utils.API2Request({ + url: `/admin/datastore/${me.datastore}/mount`, + method: 'POST', + failure: function(response) { + Ext.Msg.alert(gettext('Error'), response.htmlStatus); + }, + success: function(response, options) { + Ext.create('Proxmox.window.TaskViewer', { + upid: response.result.data, + }).show(); + }, + }); + }, + }); + + Ext.apply(me, { + tbar: [unmountBtn, mountBtn, '->', { xtype: 'proxmoxRRDTypeSelector' }], + }); + + me.mon(me.statusStore, 'load', (s, records, success) => { + let available = s.getById('is-available').data.value; + unmountBtn.setDisabled(!available); + mountBtn.setDisabled(available); + if (available) { + me.down('pbsDataStoreInfo').fireEvent('activate'); + } else { + me.down('pbsDataStoreInfo').fireEvent('deactivate'); + } + }); let sp = Ext.state.Manager.getProvider(); me.mon(sp, 'statechange', function(provider, key, value) { @@ -267,11 +321,18 @@ Ext.define('PBS.DataStoreSummary', { Proxmox.Utils.updateColumns(me); }); + me.callParent(); + Proxmox.Utils.API2Request({ url: `/config/datastore/${me.datastore}`, waitMsgTarget: me.down('pbsDataStoreInfo'), success: function(response) { - let path = Ext.htmlEncode(response.result.data.path); + let data = response.result.data; + let path = Ext.htmlEncode(data.path); + let removable = Object.prototype.hasOwnProperty.call(data, "backing-device") && + Object.prototype.hasOwnProperty.call(data, "backing-device-mount-point"); + unmountBtn.setHidden(!removable); + mountBtn.setHidden(!removable); me.down('pbsDataStoreInfo').setTitle(`${me.datastore} (${path})`); me.down('pbsDataStoreNotes').setNotes(response.result.data.comment); }, @@ -285,6 +346,14 @@ Ext.define('PBS.DataStoreSummary', { }, }); + me.on('afterrender', () => { + me.statusStore.startUpdate(); + }); + + me.on('destroy', () => { + me.statusStore.stopUpdate(); + }); + me.query('proxmoxRRDChart').forEach((chart) => { chart.setStore(me.rrdstore); }); -- 2.30.2