From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D36766C33E for ; Fri, 6 Aug 2021 11:33:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C5F97BCC2 for ; Fri, 6 Aug 2021 11:33:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 59789BCB9 for ; Fri, 6 Aug 2021 11:33:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2749E42ED9 for ; Fri, 6 Aug 2021 11:33:49 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 6 Aug 2021 11:33:45 +0200 Message-Id: <20210806093345.2330585-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.468 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [backup.rs] Subject: [pbs-devel] [PATCH proxmox-backup] tape backup: mention groups that were empty X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Aug 2021 09:33:49 -0000 otherwise a user might get a task log like this: ----- ... found 7 groups TASK OK ----- which could confuse the users as why there were no snapshots backed up Signed-off-by: Dominik Csapak --- src/api2/tape/backup.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/api2/tape/backup.rs b/src/api2/tape/backup.rs index 9f815cad..9d1ece40 100644 --- a/src/api2/tape/backup.rs +++ b/src/api2/tape/backup.rs @@ -486,11 +486,16 @@ fn backup_worker( let snapshot_list = group.list_backups(&datastore.base_path())?; // filter out unfinished backups - let mut snapshot_list = snapshot_list + let mut snapshot_list: Vec<_> = snapshot_list .into_iter() .filter(|item| item.is_finished()) .collect(); + if snapshot_list.is_empty() { + task_log!(worker, "group {} was empty", group); + continue; + } + BackupInfo::sort_list(&mut snapshot_list, true); // oldest first if latest_only { -- 2.30.2