From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 445DD6B168 for ; Tue, 3 Aug 2021 08:29:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E040EA28 for ; Tue, 3 Aug 2021 08:28:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 41F35EA1E for ; Tue, 3 Aug 2021 08:28:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0A93E42CF7 for ; Tue, 3 Aug 2021 08:28:34 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 3 Aug 2021 08:28:33 +0200 Message-Id: <20210803062833.329477-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.484 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] tape: lto: increase default timeout to 10 minutes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2021 06:29:05 -0000 it seems that for some actions or in some circumstances, two minutes is simply too short and the command aborts. Increase the default timeout to 10 minutes. While it should give most commands enough time to finish, in case of a real failure the procedure now takes up to 5 times longer, but IMHO thats an OK tradeoff. Signed-off-by: Dominik Csapak --- src/tape/drive/lto/sg_tape.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tape/drive/lto/sg_tape.rs b/src/tape/drive/lto/sg_tape.rs index 4508f6f3..893ece5d 100644 --- a/src/tape/drive/lto/sg_tape.rs +++ b/src/tape/drive/lto/sg_tape.rs @@ -130,7 +130,7 @@ pub struct SgTape { impl SgTape { - const SCSI_TAPE_DEFAULT_TIMEOUT: usize = 60*2; // 2 minutes + const SCSI_TAPE_DEFAULT_TIMEOUT: usize = 60*10; // 10 minutes /// Create a new instance /// -- 2.30.2