From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8E31F6938A for ; Mon, 26 Jul 2021 09:20:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8168B8B11 for ; Mon, 26 Jul 2021 09:20:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 750088B76 for ; Mon, 26 Jul 2021 09:20:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3FBA5425DE for ; Mon, 26 Jul 2021 09:20:42 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Mon, 26 Jul 2021 09:20:41 +0200 Message-Id: <20210726072041.810217-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.512 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] tape: changer: handle invalid descriptor data from library in status page X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2021 07:20:49 -0000 We get the descriptor length from the library and use that in 'chunks_exact', which panics on length 0. Catch that case and bail out, since that makes no sense here anyway. This could prevent a panic, in case a library sends wrong data. Signed-off-by: Dominik Csapak --- src/tape/changer/sg_pt_changer.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/tape/changer/sg_pt_changer.rs b/src/tape/changer/sg_pt_changer.rs index c94eaf2e..3124b96f 100644 --- a/src/tape/changer/sg_pt_changer.rs +++ b/src/tape/changer/sg_pt_changer.rs @@ -710,7 +710,13 @@ fn decode_element_status_page( let descr_data = reader.read_exact_allocated(len)?; - for descriptor in descr_data.chunks_exact(subhead.descriptor_length as usize) { + let descr_len = subhead.descriptor_length as usize; + + if descr_len == 0 { + bail!("got elements, but descriptor length 0"); + } + + for descriptor in descr_data.chunks_exact(descr_len) { let mut reader = &descriptor[..]; match subhead.element_type_code { -- 2.30.2