From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AF76275A3D; Tue, 13 Jul 2021 13:04:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9E43221BCC; Tue, 13 Jul 2021 13:03:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 376FE21BC3; Tue, 13 Jul 2021 13:03:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0FEA141026; Tue, 13 Jul 2021 13:03:35 +0200 (CEST) From: Oguz Bektas To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com Date: Tue, 13 Jul 2021 13:03:15 +0200 Message-Id: <20210713110314.646267-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.537 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH widget-toolkit] ServiceView: fix start/stop/restart button behavior X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 11:04:05 -0000 fix an issue where the stop button stays enabled for elements in 'startOnlyServices' after clicking a service that's not start-only Signed-off-by: Oguz Bektas --- src/node/ServiceView.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/node/ServiceView.js b/src/node/ServiceView.js index 4344c63..32d3e8a 100644 --- a/src/node/ServiceView.js +++ b/src/node/ServiceView.js @@ -124,22 +124,22 @@ Ext.define('Proxmox.node.ServiceView', { syslog_btn.enable(); if (state === 'running') { - start_btn.disable(); - restart_btn.enable(); + if (me.startOnlyServices[service]) { + stop_btn.disable(); + restart_btn.enable(); + } else { + stop_btn.enable(); + restart_btn.enable(); + start_btn.disable(); + } } else if (unit !== undefined && (unit === 'masked' || unit === 'unknown')) { start_btn.disable(); restart_btn.disable(); } else { start_btn.enable(); + stop_btn.disable(); restart_btn.disable(); } - if (!me.startOnlyServices[service]) { - if (state === 'running') { - stop_btn.enable(); - } else { - stop_btn.disable(); - } - } }; me.mon(store, 'refresh', set_button_status); -- 2.30.2