From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3462A75A33 for ; Tue, 13 Jul 2021 12:59:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2511421B2B for ; Tue, 13 Jul 2021 12:58:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AB84721B26 for ; Tue, 13 Jul 2021 12:58:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7BCDC41045 for ; Tue, 13 Jul 2021 12:58:50 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 13 Jul 2021 12:58:49 +0200 Message-Id: <20210713105849.3374725-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.605 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v2] ui: NodeInfo: add link to repositories X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 10:59:21 -0000 to guide the user to the repository panel from the dashboard Signed-off-by: Dominik Csapak --- changes from v1: * use different icon * make sure the icon stays black (i did not see the purple link... should check my eyes^^) * use better variable name * use tooltip regarding the use of a 'normal' link, there are two alternatives as i see it, and both are not optimal: * create an component inline (Ext.create) and add a handler, etc. i'd avoid that in a viewmodel formula (do not know the side effects of that) * add a click handler/tooltip across the whole 'value' part of the panel idk if we want that, it would mean the tooltip/click handler is for the whole value part if one of those solutions is preferred, please tell, i'll send a v3 www/panel/NodeInfo.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/panel/NodeInfo.js b/www/panel/NodeInfo.js index ff96e8fc..a8c450f6 100644 --- a/www/panel/NodeInfo.js +++ b/www/panel/NodeInfo.js @@ -46,7 +46,11 @@ Ext.define('PBS.NodeInfoPanel', { }, repoStatusMessage: function(get) { const status = get('repoStatus'); - return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server'); + let repoLink = ` + + `; + return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server') + repoLink; }, }, }, -- 2.30.2