From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9C8B875904 for ; Tue, 13 Jul 2021 11:11:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 921501E9AC for ; Tue, 13 Jul 2021 11:11:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C30F31E9A2 for ; Tue, 13 Jul 2021 11:11:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 99DF840482 for ; Tue, 13 Jul 2021 11:11:26 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 13 Jul 2021 11:11:25 +0200 Message-Id: <20210713091125.2064985-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210713091125.2064985-1-d.csapak@proxmox.com> References: <20210713091125.2064985-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.612 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [restore.rs] Subject: [pbs-devel] [PATCH proxmox-backup 2/2] api2: tape: restore: add warning for list restore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 09:11:27 -0000 if an error occurs, the snapshot dirs will already be created, and we do not clean them up (some might already be finished). Warn the user that they are not cleaned up. Signed-off-by: Dominik Csapak --- src/api2/tape/restore.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/api2/tape/restore.rs b/src/api2/tape/restore.rs index 68033c4a..f959a856 100644 --- a/src/api2/tape/restore.rs +++ b/src/api2/tape/restore.rs @@ -647,6 +647,10 @@ fn restore_list_worker( Ok(()) }); + if res.is_err() { + task_warn!(worker, "Error during restore, partially restored snapshots will NOT be cleaned up"); + } + match std::fs::remove_dir_all(&base_path) { Ok(()) => {} Err(err) => task_warn!(worker, "error cleaning up: {}", err), -- 2.30.2