From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B2EC871544 for ; Mon, 28 Jun 2021 20:41:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 74CC72E98D for ; Mon, 28 Jun 2021 20:41:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3FD8C2E979 for ; Mon, 28 Jun 2021 20:41:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 104E8467D3 for ; Mon, 28 Jun 2021 20:41:24 +0200 (CEST) From: Stoiko Ivanov To: pbs-devel@lists.proxmox.com Date: Mon, 28 Jun 2021 18:41:06 +0000 Message-Id: <20210628184109.110296-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.586 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v2 0/3] acme: add sleep for dns record propagation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 18:41:26 -0000 changes v1 -> v2 (based on Thomas' feedback - huge thx!): * moved the sleep to only run for setup not for teardown * added a check to only sleep and print the message if the delay is > 0 for consistency, and to be able to skip it (e.g. for a simple powerdns-setup) * while looking through the code found a small glitch in an error message (the fix is in patch 1/3) forgot to mention that the patches were developed and tested on top of the current stable-1 branch (they apply cleanly on master, but I did not explicitly test on master) cover-letter for v1: The issue was brought up in our community forum: https://forum.proxmox.com/threads/acme-configuration-via-gui.91381/ While I could not directly reproduce it (writing to a pdns-database is faster than waiting on cloud-flare to propagate their records) I compared the task-log to the one from PMG. The use of tokio::time::sleep was taken from the other delays in api2::node::certificate, for the rest I mostly trusted the compiler warnings and rustfmt. Stoiko Ivanov (3): acme: plugin: fix error message config: acme: make validation_delay crate public fix #3496: acme: plugin: add sleep for dns propagation src/acme/plugin.rs | 19 +++++++++++++++++-- src/config/acme/plugin.rs | 2 +- 2 files changed, 18 insertions(+), 3 deletions(-) -- 2.20.1