From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0CC6F7487A for ; Tue, 22 Jun 2021 09:56:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 099C823872 for ; Tue, 22 Jun 2021 09:56:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A007E237F7 for ; Tue, 22 Jun 2021 09:56:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 71D55437A2 for ; Tue, 22 Jun 2021 09:56:26 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Tue, 22 Jun 2021 09:56:17 +0200 Message-Id: <20210622075620.28681-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.246 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, proxmox-backup-manager.rs, verify.rs] Subject: [pbs-devel] [PATCH v2 proxmox-backup 0/3] close #3459: add --ignore-verified and --outdated-after to CLI and api2 X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2021 07:56:31 -0000 v2, based on Dominik Csapak 's feedback: - new function is now the filter, instead of returning a closure - used extract_output_format in the binary Moved the snapshot filter into a function, so verify jobs and the datastore verify endpoint don't have duplicated code. Also adds --ignore-verified and --outdated-after to the CLI and api2 endpoint for verifing datastores. It might make sense to also make those option avaiable in the WebUI. Hannes Laimer (3): close #3459: verify-job: move snapshot filter into function close #3459: api2: add ignore-verified and outdated-after to datastore verify endpoint close: #3459: manager_bin: add --ignore-verified and --outdated-after parameters src/api2/admin/datastore.rs | 28 +++++++++++++++++++++++--- src/backup/verify.rs | 27 +++++++++++++++++++++++++ src/bin/proxmox-backup-manager.rs | 14 ++++++++++--- src/server/verify_job.rs | 33 +++++++++---------------------- 4 files changed, 72 insertions(+), 30 deletions(-) -- 2.20.1