From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A98C670828 for ; Mon, 7 Jun 2021 15:06:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 750F91177D for ; Mon, 7 Jun 2021 15:06:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BD2B211768 for ; Mon, 7 Jun 2021 15:06:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 82B2042F3F for ; Mon, 7 Jun 2021 15:06:45 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Mon, 7 Jun 2021 15:06:44 +0200 Message-Id: <20210607130645.11838-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.969 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/2] ui: form/DriveSelector: do not autoselect the drive X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 13:06:51 -0000 in case an invalid drive was configured, now it marks the field invalid instead of autoselecting the first valid one this could have lead to users configuring the wrong drive in a tape-backup-job when they edited one Signed-off-by: Dominik Csapak --- www/tape/form/DriveSelector.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/tape/form/DriveSelector.js b/www/tape/form/DriveSelector.js index 333989a9..9c793e46 100644 --- a/www/tape/form/DriveSelector.js +++ b/www/tape/form/DriveSelector.js @@ -16,6 +16,8 @@ Ext.define('PBS.form.DriveSelector', { sorters: 'name', }, + autoSelect: false, + listConfig: { columns: [ { -- 2.20.1