From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 331B271C84 for ; Fri, 21 May 2021 12:21:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 21482D17B for ; Fri, 21 May 2021 12:20:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C87CCD149 for ; Fri, 21 May 2021 12:20:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1C1B842A59 for ; Fri, 21 May 2021 12:20:23 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 21 May 2021 12:20:18 +0200 Message-Id: <20210521102022.26859-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210521102022.26859-1-d.csapak@proxmox.com> References: <20210521102022.26859-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -1.586 Adjusted score from AWL reputation of From: address ENA_SUBJ_ODD_CASE 3.2 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v4 1/5] ui: tape/TapeRestore: fix small DataStoreMappingGrid bugs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2021 10:21:01 -0000 enable scrolling by default, and handle the case that getErrors gets called when the component is not yet rendered Signed-off-by: Dominik Csapak --- www/tape/window/TapeRestore.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js index 9967d9d8..2a876619 100644 --- a/www/tape/window/TapeRestore.js +++ b/www/tape/window/TapeRestore.js @@ -203,6 +203,8 @@ Ext.define('PBS.TapeManagement.DataStoreMappingGrid', { alias: 'widget.pbsDataStoreMappingField', mixins: ['Ext.form.field.Field'], + scrollable: true, + getValue: function() { let me = this; let datastores = []; @@ -246,15 +248,20 @@ Ext.define('PBS.TapeManagement.DataStoreMappingGrid', { }); } + let el = me.getActionEl(); if (error) { me.addCls(['x-form-trigger-wrap-default', 'x-form-trigger-wrap-invalid']); let errorMsg = gettext("Need at least one mapping"); - me.getActionEl().dom.setAttribute('data-errorqtip', errorMsg); + if (el) { + el.dom.setAttribute('data-errorqtip', errorMsg); + } return [errorMsg]; } me.removeCls(['x-form-trigger-wrap-default', 'x-form-trigger-wrap-invalid']); - me.getActionEl().dom.setAttribute('data-errorqtip', ""); + if (el) { + el.dom.setAttribute('data-errorqtip', ""); + } return []; }, -- 2.20.1