From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 982507088E for ; Fri, 14 May 2021 10:40:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85B5514491 for ; Fri, 14 May 2021 10:39:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 15EA114472 for ; Fri, 14 May 2021 10:39:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DC49342903 for ; Fri, 14 May 2021 10:39:29 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 14 May 2021 10:39:29 +0200 Message-Id: <20210514083929.29664-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [email.rs] Subject: [pbs-devel] [PATCH proxmox] proxmox/tools/email: adapt tests to changes to sendmail X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2021 08:40:00 -0000 with test1/3 we only tested the regex, which is now gone transform the tests to valid emails, so we test this also and rename them to know what they should test Signed-off-by: Dominik Csapak --- the first/last test now generate real emails to root@localhost, if we do not want that, we should remove those tests entirely proxmox/src/tools/email.rs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/proxmox/src/tools/email.rs b/proxmox/src/tools/email.rs index 0b92a5b..fc69488 100644 --- a/proxmox/src/tools/email.rs +++ b/proxmox/src/tools/email.rs @@ -113,20 +113,20 @@ mod test { use crate::tools::email::sendmail; #[test] - fn test1() { + fn send_email_to_root_localhost() { let result = sendmail( - &["somenotvalidemail!", "somealmostvalid email"], + &["root@localhost"], "Subject1", Some("TEXT"), Some("HTML"), - Some("bim@bam.bum"), + Some("root@localhost"), Some("test1"), ); - assert!(result.is_err()); + assert!(result.is_ok()); } #[test] - fn test2() { + fn email_without_recipients() { let result = sendmail( &[], "Subject2", @@ -139,15 +139,15 @@ mod test { } #[test] - fn test3() { + fn email_with_non_existant_recipient() { let result = sendmail( - &["a@b.c"], + &["some-nonexistant-proxmox-user"], "Subject3", None, Some("HTML"), - Some("notv@lid.com!"), + None, Some("test1"), ); - assert!(result.is_err()); + assert!(result.is_ok()); } } -- 2.20.1