From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D9D7379E2E for ; Thu, 6 May 2021 09:15:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C8E931C1E5 for ; Thu, 6 May 2021 09:14:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6A3661C1DA for ; Thu, 6 May 2021 09:14:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3AC3742A2C for ; Thu, 6 May 2021 09:14:44 +0200 (CEST) Date: Thu, 6 May 2021 09:14:43 +0200 From: Wolfgang Bumiller To: Dietmar Maurer Cc: Proxmox Backup Server development discussion Message-ID: <20210506071443.5sghhhv5htczhzh6@wobu-vie.proxmox.com> References: <228044467.236.1620284506924@webmail.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <228044467.236.1620284506924@webmail.proxmox.com> User-Agent: NeoMutt/20180716 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH backup] client: use build_authority in build_uri X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 07:15:14 -0000 On Thu, May 06, 2021 at 09:01:46AM +0200, Dietmar Maurer wrote: > In general a good idea, but we now merge code > from two independent http client implementation (making them > dependent)? I mean... it's called "tools::http"... as in "http utilities", which IMO does not really sound like "this is an independent http client, which must not be reused"... ;-) And it's a rather thin layer around hyper (the *actual* client...) to add proxy support which, too, is something that we may at some point want to reuse without the rest of `SimpleHttp`, no?