From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 926BA795EB for ; Tue, 4 May 2021 15:14:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E8159B72 for ; Tue, 4 May 2021 15:14:07 +0200 (CEST) Received: from gaia.proxmox.com (unknown [94.136.29.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6D69A9B61 for ; Tue, 4 May 2021 15:14:06 +0200 (CEST) Received: from gaia.proxmox.com (localhost.localdomain [127.0.0.1]) by gaia.proxmox.com (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 144DAZ201480560; Tue, 4 May 2021 15:10:35 +0200 Received: (from oguz@localhost) by gaia.proxmox.com (8.15.2/8.15.2/Submit) id 144DAZGQ1480558; Tue, 4 May 2021 15:10:35 +0200 From: Oguz Bektas To: pbs-devel@lists.proxmox.com Date: Tue, 4 May 2021 15:10:35 +0200 Message-Id: <20210504131035.1480432-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 AWL -0.026 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs] Subject: [pbs-devel] [PATCH backup] tape: create drive-state and changer-state directories with correct permissions X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 May 2021 13:14:37 -0000 we need to also pass the intermediate_opts to avoid creating /run/proxmox-backup/ with root as owner (in case it does not exist yet) Signed-off-by: Oguz Bektas --- src/tape/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tape/mod.rs b/src/tape/mod.rs index ed03d8a7..de15800f 100644 --- a/src/tape/mod.rs +++ b/src/tape/mod.rs @@ -85,7 +85,7 @@ pub fn create_drive_state_dir() -> Result<(), Error> { .owner(backup_user.uid) .group(backup_user.gid); - create_path(DRIVE_STATE_DIR, None, Some(options)) + create_path(DRIVE_STATE_DIR, Some(options.clone()), Some(options)) .map_err(|err: Error| format_err!("unable to create drive state dir - {}", err))?; Ok(()) @@ -100,7 +100,7 @@ pub fn create_changer_state_dir() -> Result<(), Error> { .owner(backup_user.uid) .group(backup_user.gid); - create_path(CHANGER_STATE_DIR, None, Some(options)) + create_path(CHANGER_STATE_DIR, Some(options.clone()), Some(options)) .map_err(|err: Error| format_err!("unable to create changer state dir - {}", err))?; Ok(()) -- 2.20.1