From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <w.bumiller@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id E644C78636
 for <pbs-devel@lists.proxmox.com>; Fri, 30 Apr 2021 09:25:38 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id DBE8F24FAE
 for <pbs-devel@lists.proxmox.com>; Fri, 30 Apr 2021 09:25:38 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 6CEB224FA3
 for <pbs-devel@lists.proxmox.com>; Fri, 30 Apr 2021 09:25:38 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3DE134295A
 for <pbs-devel@lists.proxmox.com>; Fri, 30 Apr 2021 09:25:38 +0200 (CEST)
Date: Fri, 30 Apr 2021 09:25:37 +0200
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>
Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Message-ID: <20210430072537.eha3objxynpvss5z@wobu-vie.proxmox.com>
References: <20210429131322.24319-1-w.bumiller@proxmox.com>
 <20210429131322.24319-3-w.bumiller@proxmox.com>
 <d1481807-04ab-36c7-b9fc-3a070c191a20@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d1481807-04ab-36c7-b9fc-3a070c191a20@proxmox.com>
User-Agent: NeoMutt/20180716
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.022 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [REBASED backup 02/14] add acme config and client
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 30 Apr 2021 07:25:38 -0000

On Fri, Apr 30, 2021 at 08:16:39AM +0200, Dietmar Maurer wrote:
> Is it possible to split this patch? I would like to separate the config/*
> part.
> 
> IMHO this should not depend on acme/

The config also contains the validation plugin configuration, and the
plugins' implementations need to access the ACME challenge data to build
the validation info (dns entry or http server).
One alternative would be to pass all the relevant low level client
structs (from proxmox-acme-rs), but I want the high level client to
manage these and preferably not expose them directly.
Another alternative would be to split out the plugins' implementations,
but I don't see much real value in that.