From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AADCC77D98 for ; Thu, 29 Apr 2021 10:23:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9446818763 for ; Thu, 29 Apr 2021 10:23:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B1FA01875A for ; Thu, 29 Apr 2021 10:23:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 80B724295A for ; Thu, 29 Apr 2021 10:23:03 +0200 (CEST) From: Stefan Reiter To: pbs-devel@lists.proxmox.com Date: Thu, 29 Apr 2021 10:22:53 +0200 Message-Id: <20210429082253.21300-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [disk.rs] Subject: [pbs-devel] [PATCH proxmox-backup] file-restore: use 'norecovery' for xfs filesystem X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2021 08:23:43 -0000 This allows mounting XFS partitons with 'dirty' states, like from a running VM. Otherwise XFS tries to write recovery information, which fails on a read-only mount. Tested-by: Thomas Lamprecht Tested-by: Dominik Csapak Signed-off-by: Stefan Reiter --- Gave it a spin myself now too, works fine. src/bin/proxmox_restore_daemon/disk.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/bin/proxmox_restore_daemon/disk.rs b/src/bin/proxmox_restore_daemon/disk.rs index 0b564e42..b0d5f72d 100644 --- a/src/bin/proxmox_restore_daemon/disk.rs +++ b/src/bin/proxmox_restore_daemon/disk.rs @@ -25,6 +25,8 @@ lazy_static! { m.insert("ext3", "noload"); m.insert("ext4", "noload"); + m.insert("xfs", "norecovery"); + // ufs2 is used as default since FreeBSD 5.0 released in 2003, so let's assume that // whatever the user is trying to restore is not using anything older... m.insert("ufs", "ufstype=ufs2"); -- 2.20.1