From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4F0B177AC9 for ; Wed, 28 Apr 2021 18:07:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4300D119AE for ; Wed, 28 Apr 2021 18:07:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A6AC91198D for ; Wed, 28 Apr 2021 18:07:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6D7D646497 for ; Wed, 28 Apr 2021 18:07:04 +0200 (CEST) From: Stefan Reiter To: pbs-devel@lists.proxmox.com Date: Wed, 28 Apr 2021 18:06:55 +0200 Message-Id: <20210428160655.29941-4-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210428160655.29941-1-s.reiter@proxmox.com> References: <20210428160655.29941-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup-qemu 3/3] access: use bigger cache and LRU chunk reader X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 16:07:05 -0000 Values chosen by fair dice roll, seems to be a good sweet spot on my machine where any less causes performance degradation but any more doesn't really make it go any faster. Keep in mind that those values are per drive in an actual restore, but also allocated via mmap on a disk-backed path, so can be swapped out of memory easily. Signed-off-by: Stefan Reiter --- src/restore.rs | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/restore.rs b/src/restore.rs index 0790d7f..b43c383 100644 --- a/src/restore.rs +++ b/src/restore.rs @@ -218,16 +218,21 @@ impl RestoreTask { let index = client.download_fixed_index(&manifest, &archive_name).await?; let archive_size = index.index_bytes(); - let most_used = index.find_most_used_chunks(8); + let most_used = index.find_most_used_chunks(16); // 64 MB most used cache let file_info = manifest.lookup_file_info(&archive_name)?; - let chunk_reader = RemoteChunkReader::new( + let chunk_reader = RemoteChunkReader::new_lru_cached( Arc::clone(&client), self.crypt_config.clone(), file_info.chunk_crypt_mode(), most_used, - ); + 64, // 256 MB LRU cache + index + .chunk_info(0) + .map(|info| info.size() as usize) + .unwrap_or(4 * 1024 * 1024), + )?; let reader = AsyncIndexReader::new(index, chunk_reader); -- 2.20.1