From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9A4EC75D49 for ; Thu, 22 Apr 2021 16:13:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8959B1D706 for ; Thu, 22 Apr 2021 16:12:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1BC0A1D6FA for ; Thu, 22 Apr 2021 16:12:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D96704363B for ; Thu, 22 Apr 2021 16:12:50 +0200 (CEST) Date: Thu, 22 Apr 2021 16:12:49 +0200 From: Wolfgang Bumiller To: pbs-devel@lists.proxmox.com Message-ID: <20210422141249.ezsfkyennmokvgfe@wobu-vie.proxmox.com> References: <20210422140213.30989-1-w.bumiller@proxmox.com> <20210422140213.30989-26-w.bumiller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210422140213.30989-26-w.bumiller@proxmox.com> User-Agent: NeoMutt/20180716 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.039 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [client.rs, mod.rs, plugin.rs] Subject: Re: [pbs-devel] [PATCH v2 backup 25/27] acme: create directories as needed X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 14:13:22 -0000 Ah damn, I failed to include a fixup in this patch: On Thu, Apr 22, 2021 at 04:02:11PM +0200, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > src/acme/client.rs | 2 ++ > src/config/acme/mod.rs | 27 +++++++++++++++++++++++++++ > src/config/acme/plugin.rs | 7 +++++-- > 3 files changed, 34 insertions(+), 2 deletions(-) > > diff --git a/src/acme/client.rs b/src/acme/client.rs > index dea2e3b0..83bfdf9e 100644 > --- a/src/acme/client.rs > +++ b/src/acme/client.rs > @@ -124,6 +124,7 @@ impl AcmeClient { > > let _ = self.register_account(account).await?; > > + crate::config::acme::make_acme_account_dir()?; > let account_path = account_path(account_name.as_ref()); > let file = OpenOptions::new() > .write(true) > @@ -151,6 +152,7 @@ impl AcmeClient { > let account_path = self.account_path.as_ref().ok_or_else(|| { > format_err!("no account path set, cannot save upated account information") > })?; > + crate::config::acme::make_acme_account_dir()?; > replace_file( > account_path, > &data, > diff --git a/src/config/acme/mod.rs b/src/config/acme/mod.rs > index ac409c20..0ed4974d 100644 > --- a/src/config/acme/mod.rs > +++ b/src/config/acme/mod.rs > @@ -7,14 +7,41 @@ use serde::{Deserialize, Serialize}; > > use proxmox::api::api; > use proxmox::sys::error::SysError; > +use proxmox::tools::fs::CreateOptions; > > use crate::api2::types::{PROXMOX_SAFE_ID_FORMAT, PROXMOX_SAFE_ID_REGEX}; > use crate::tools::ControlFlow; > > +pub(crate) const ACME_DIR: &str = configdir!("/acme/accounts"); ^ This should obviously not include the `/accounts` part... > pub(crate) const ACME_ACCOUNT_DIR: &str = configdir!("/acme/accounts");