From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6BCF4739C2 for ; Fri, 16 Apr 2021 12:29:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 124C72358A for ; Fri, 16 Apr 2021 12:29:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3FC0123555 for ; Fri, 16 Apr 2021 12:29:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 01B8C45AFE for ; Fri, 16 Apr 2021 12:29:12 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 16 Apr 2021 12:29:04 +0200 Message-Id: <20210416102910.8506-9-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210416102910.8506-1-d.csapak@proxmox.com> References: <20210416102910.8506-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.162 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [docgen.rs, pmtx.rs] Subject: [pbs-devel] [PATCH proxmox-backup v2 08/14] bin: clippy fixes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Apr 2021 10:29:44 -0000 fixes: * `len() < 1` => `is_empty()` * redundant closure * unnecessary return Signed-off-by: Dominik Csapak --- src/bin/docgen.rs | 2 +- src/bin/pmtx.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/docgen.rs b/src/bin/docgen.rs index 9df9f33b..1f9657ea 100644 --- a/src/bin/docgen.rs +++ b/src/bin/docgen.rs @@ -46,7 +46,7 @@ fn main() -> Result<(), Error> { let (_prefix, args) = get_args(); - if args.len() < 1 { + if args.is_empty() { bail!("missing arguments"); } diff --git a/src/bin/pmtx.rs b/src/bin/pmtx.rs index 88074002..4a59d624 100644 --- a/src/bin/pmtx.rs +++ b/src/bin/pmtx.rs @@ -262,7 +262,7 @@ fn unload( if let Some(to_slot) = status.find_free_slot(false) { sg_pt_changer::unload(&mut file, to_slot, drivenum)?; - return Ok(()); + Ok(()) } else { bail!("Drive '{}' unload failure - no free slot", drivenum); } -- 2.20.1