From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 779447393A for ; Fri, 16 Apr 2021 12:29:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 36C3D2356E for ; Fri, 16 Apr 2021 12:29:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A157523538 for ; Fri, 16 Apr 2021 12:29:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6D01A45B2F for ; Fri, 16 Apr 2021 12:29:11 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 16 Apr 2021 12:28:58 +0200 Message-Id: <20210416102910.8506-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210416102910.8506-1-d.csapak@proxmox.com> References: <20210416102910.8506-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.163 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [vtape.name] Subject: [pbs-devel] [PATCH proxmox-backup v2 02/14] tape/changer: clippy fixes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Apr 2021 10:29:13 -0000 fixes: * unnecessary referencing * `.map(|v| *v)` => `.copied()` Signed-off-by: Dominik Csapak --- src/tape/changer/online_status_map.rs | 4 ++-- src/tape/changer/sg_pt_changer.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tape/changer/online_status_map.rs b/src/tape/changer/online_status_map.rs index e30cd17b..324d1fec 100644 --- a/src/tape/changer/online_status_map.rs +++ b/src/tape/changer/online_status_map.rs @@ -137,7 +137,7 @@ pub fn update_online_status(state_path: &Path, changer: Option<&str>) -> Result< for mut changer_config in changers { if let Some(changer) = changer { - if changer != &changer_config.name { + if changer != changer_config.name { continue; } found_changer = true; @@ -157,7 +157,7 @@ pub fn update_online_status(state_path: &Path, changer: Option<&str>) -> Result< let vtapes: Vec = config.convert_to_typed_array("virtual")?; for mut vtape in vtapes { if let Some(changer) = changer { - if changer != &vtape.name { + if changer != vtape.name { continue; } found_changer = true; diff --git a/src/tape/changer/sg_pt_changer.rs b/src/tape/changer/sg_pt_changer.rs index 785fc9ce..b559653c 100644 --- a/src/tape/changer/sg_pt_changer.rs +++ b/src/tape/changer/sg_pt_changer.rs @@ -392,7 +392,7 @@ pub fn read_element_status(file: &mut F) -> Result for drive in status.drives.iter_mut() { if let Some(source_address) = drive.loaded_slot { let source_address = source_address as u16; - drive.loaded_slot = slot_map.get(&source_address).map(|v| *v); + drive.loaded_slot = slot_map.get(&source_address).copied(); } } -- 2.20.1