From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CE3AF739DE for ; Fri, 16 Apr 2021 12:29:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3BB71235D5 for ; Fri, 16 Apr 2021 12:29:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A69DF23561 for ; Fri, 16 Apr 2021 12:29:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 732EA45B1C for ; Fri, 16 Apr 2021 12:29:12 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 16 Apr 2021 12:29:10 +0200 Message-Id: <20210416102910.8506-15-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210416102910.8506-1-d.csapak@proxmox.com> References: <20210416102910.8506-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.162 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [auth.rs] Subject: [pbs-devel] [PATCH proxmox-backup v2 14/14] bin/proxmox-restore-daemon: clippy fixes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Apr 2021 10:29:46 -0000 fixes: * unnecessary reference * unnecessary return * absurd extreme comparisons Signed-off-by: Dominik Csapak --- src/bin/proxmox_restore_daemon/auth.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/bin/proxmox_restore_daemon/auth.rs b/src/bin/proxmox_restore_daemon/auth.rs index 0973849e..1cf5a2c4 100644 --- a/src/bin/proxmox_restore_daemon/auth.rs +++ b/src/bin/proxmox_restore_daemon/auth.rs @@ -22,13 +22,13 @@ impl ApiAuth for StaticAuth { _user_info: &CachedUserInfo, ) -> Result { match headers.get(hyper::header::AUTHORIZATION) { - Some(header) if header.to_str().unwrap_or("") == &self.ticket => { + Some(header) if header.to_str().unwrap_or("") == self.ticket => { Ok(Authid::root_auth_id().to_owned()) } _ => { - return Err(AuthError::Generic(format_err!( + Err(AuthError::Generic(format_err!( "invalid file restore ticket provided" - ))); + ))) } } } @@ -38,7 +38,7 @@ pub fn ticket_auth() -> Result { let mut ticket_file = File::open(TICKET_FILE)?; let mut ticket = String::new(); let len = ticket_file.read_to_string(&mut ticket)?; - if len <= 0 { + if len == 0 { bail!("invalid ticket: cannot be empty"); } Ok(StaticAuth { ticket }) -- 2.20.1