From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8BA9F7170B for ; Thu, 8 Apr 2021 13:39:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 81B001A99C for ; Thu, 8 Apr 2021 13:39:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E76DB1A97B for ; Thu, 8 Apr 2021 13:39:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AC796459F3 for ; Thu, 8 Apr 2021 13:39:21 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 8 Apr 2021 13:39:19 +0200 Message-Id: <20210408113920.24416-6-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210408113920.24416-1-d.csapak@proxmox.com> References: <20210408113920.24416-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.168 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 6/7] ui: tape/ChangerStatus: hide selector for single drives in barcode-label X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 11:39:53 -0000 it is rather pointless to let the user select something were there is no choice. We have to keep the window though, since the user may want to choose a pool Signed-off-by: Dominik Csapak --- www/tape/ChangerStatus.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js index 9b1d8c47..2f6e29df 100644 --- a/www/tape/ChangerStatus.js +++ b/www/tape/ChangerStatus.js @@ -302,6 +302,8 @@ Ext.define('PBS.TapeManagement.ChangerStatus', { return; } + let singleDrive = me.drives.length === 1 ? me.drives[0] : undefined; + Ext.create('Proxmox.window.Edit', { title: gettext('Barcode Label'), showTaskViewer: true, @@ -315,9 +317,11 @@ Ext.define('PBS.TapeManagement.ChangerStatus', { items: [ { - xtype: 'pbsDriveSelector', + xtype: singleDrive === undefined ? 'pbsDriveSelector' : 'displayfield', fieldLabel: gettext('Drive'), + submitValue: true, name: 'drive', + value: singleDrive, changer: changer, }, { -- 2.20.1