From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9A99D70CAF for ; Tue, 6 Apr 2021 08:27:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 974BD29AED for ; Tue, 6 Apr 2021 08:27:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3A65129AC0 for ; Tue, 6 Apr 2021 08:27:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EC5CC45784 for ; Tue, 6 Apr 2021 08:27:48 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 6 Apr 2021 08:27:43 +0200 Message-Id: <20210406062747.9356-9-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210406062747.9356-1-d.csapak@proxmox.com> References: <20210406062747.9356-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.172 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 08/12] bin: clippy fixes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2021 06:27:50 -0000 fixes: * `len() < 1` => `is_empty()` * redundant closure * unnecessary return Signed-off-by: Dominik Csapak --- src/bin/docgen.rs | 2 +- src/bin/pmt.rs | 2 +- src/bin/pmtx.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bin/docgen.rs b/src/bin/docgen.rs index 9df9f33b..1f9657ea 100644 --- a/src/bin/docgen.rs +++ b/src/bin/docgen.rs @@ -46,7 +46,7 @@ fn main() -> Result<(), Error> { let (_prefix, args) = get_args(); - if args.len() < 1 { + if args.is_empty() { bail!("missing arguments"); } diff --git a/src/bin/pmt.rs b/src/bin/pmt.rs index a097df2c..b424b045 100644 --- a/src/bin/pmt.rs +++ b/src/bin/pmt.rs @@ -781,7 +781,7 @@ fn st_options( list } Some(false) | None => { - options.unwrap_or_else(|| Vec::new()) + options.unwrap_or_else(Vec::new) } }; diff --git a/src/bin/pmtx.rs b/src/bin/pmtx.rs index 85114811..aef425b4 100644 --- a/src/bin/pmtx.rs +++ b/src/bin/pmtx.rs @@ -262,7 +262,7 @@ fn unload( if let Some(to_slot) = status.find_free_slot(false) { sg_pt_changer::unload(&mut file, to_slot, drivenum)?; - return Ok(()); + Ok(()) } else { bail!("Drive '{}' unload failure - no free slot", drivenum); } -- 2.20.1