From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6806870CAD for ; Tue, 6 Apr 2021 08:27:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6559E29AD9 for ; Tue, 6 Apr 2021 08:27:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0EDAA29AB2 for ; Tue, 6 Apr 2021 08:27:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CE033459C6 for ; Tue, 6 Apr 2021 08:27:48 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 6 Apr 2021 08:27:41 +0200 Message-Id: <20210406062747.9356-7-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210406062747.9356-1-d.csapak@proxmox.com> References: <20210406062747.9356-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.173 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 06/12] backup: clippy fixes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2021 06:27:50 -0000 fixes: * clone on copy type * annotate 'wrong_self_convention' Signed-off-by: Dominik Csapak --- src/backup/key_derivation.rs | 6 +++--- src/backup/manifest.rs | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/backup/key_derivation.rs b/src/backup/key_derivation.rs index 5b46a70c..ece04c4f 100644 --- a/src/backup/key_derivation.rs +++ b/src/backup/key_derivation.rs @@ -119,7 +119,7 @@ impl KeyConfig { /// Creates a new, unencrypted key. pub fn without_password(raw_key: [u8; 32]) -> Result { // always compute fingerprint - let crypt_config = CryptConfig::new(raw_key.clone())?; + let crypt_config = CryptConfig::new(raw_key)?; let fingerprint = Some(crypt_config.fingerprint()); let created = proxmox::tools::time::epoch_i64(); @@ -186,7 +186,7 @@ impl KeyConfig { let created = proxmox::tools::time::epoch_i64(); // always compute fingerprint - let crypt_config = CryptConfig::new(raw_key.clone())?; + let crypt_config = CryptConfig::new(*raw_key)?; let fingerprint = Some(crypt_config.fingerprint()); Ok(Self { @@ -257,7 +257,7 @@ impl KeyConfig { let mut result = [0u8; 32]; result.copy_from_slice(&key); - let crypt_config = CryptConfig::new(result.clone())?; + let crypt_config = CryptConfig::new(result)?; let fingerprint = crypt_config.fingerprint(); if let Some(ref stored_fingerprint) = self.fingerprint { if &fingerprint != stored_fingerprint { diff --git a/src/backup/manifest.rs b/src/backup/manifest.rs index 47f9cadc..f3a149bd 100644 --- a/src/backup/manifest.rs +++ b/src/backup/manifest.rs @@ -148,6 +148,7 @@ impl BackupManifest { } // Generate canonical json + #[allow(clippy::wrong_self_convention)] fn to_canonical_json(value: &Value) -> Result, Error> { crate::tools::json::to_canonical_json(value) } -- 2.20.1