From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 312506A75E for ; Mon, 15 Mar 2021 13:02:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 29A712086E for ; Mon, 15 Mar 2021 13:01:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A89C420865 for ; Mon, 15 Mar 2021 13:01:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6E456436A3 for ; Mon, 15 Mar 2021 13:01:47 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Mon, 15 Mar 2021 13:01:46 +0100 Message-Id: <20210315120146.13963-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.187 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] ui: tape/DriveStatus: open task window on click on state X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2021 12:02:18 -0000 Signed-off-by: Dominik Csapak --- the code is not pretty, but thats afaics the only way, without putting that functionality inside the InfoWidget (but we only need it now, so maybe wait until we need it again?) the extra css class is necessary, since we cannot change the class of the div below (it is part of a template that gets rewritten) www/css/ext6-pbs.css | 4 ++++ www/tape/DriveStatus.js | 28 ++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css index 5608a727..51d68711 100644 --- a/www/css/ext6-pbs.css +++ b/www/css/ext6-pbs.css @@ -273,3 +273,7 @@ span.snapshot-comment-column { height: 20px; background-image:url(../images/icon-tape-drive.svg); } + +.info-pointer div.right-aligned { + cursor: pointer; +} diff --git a/www/tape/DriveStatus.js b/www/tape/DriveStatus.js index 3b67ce6f..bf083851 100644 --- a/www/tape/DriveStatus.js +++ b/www/tape/DriveStatus.js @@ -400,6 +400,7 @@ Ext.define('PBS.TapeManagement.DriveInfoPanel', { }, { xtype: 'pmxInfoWidget', + reference: 'statewidget', title: gettext('State'), bind: { data: { @@ -409,6 +410,23 @@ Ext.define('PBS.TapeManagement.DriveInfoPanel', { }, ], + clickState: function(e, t, eOpts) { + let me = this; + let vm = me.getViewModel(); + let drive = vm.get('drive'); + if (t.classList.contains('right-aligned')) { + let upid = drive.state; + if (!upid || !upid.startsWith("UPID")) { + return; + } + + Ext.create('Proxmox.window.TaskViewer', { + autoShow: true, + upid, + }); + } + }, + updateData: function(store) { let me = this; if (!store) { @@ -421,6 +439,16 @@ Ext.define('PBS.TapeManagement.DriveInfoPanel', { let vm = me.getViewModel(); vm.set('drive', record.data); + let stateWidget = me.down('pmxInfoWidget[reference=statewidget]'); + let stateEl = stateWidget.getEl(); + stateEl.removeListener('click', me.clickState); + if (record.data.state) { + stateEl.on('click', me.clickState, me); + stateEl.addCls('info-pointer'); + } else { + stateEl.removeCls('info-pointer'); + } + vm.notify(); }, -- 2.20.1