From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DAEDE6AF9D for ; Mon, 8 Mar 2021 10:06:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CCB1A1C0E0 for ; Mon, 8 Mar 2021 10:06:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1B07E1C0D6 for ; Mon, 8 Mar 2021 10:06:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D438040391 for ; Mon, 8 Mar 2021 10:06:07 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Mon, 8 Mar 2021 10:06:07 +0100 Message-Id: <20210308090607.28658-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210308090607.28658-1-d.csapak@proxmox.com> References: <20210308090607.28658-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.196 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/Drive{Config, Status} move actions to status panel X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 09:06:38 -0000 so that the 'DriveConfig' panel is purely for configuration Signed-off-by: Dominik Csapak --- www/tape/DriveConfig.js | 55 ----------------------------------------- www/tape/DriveStatus.js | 42 +++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+), 55 deletions(-) diff --git a/www/tape/DriveConfig.js b/www/tape/DriveConfig.js index de6a0525..763f8e55 100644 --- a/www/tape/DriveConfig.js +++ b/www/tape/DriveConfig.js @@ -55,34 +55,6 @@ Ext.define('PBS.TapeManagement.DrivePanel', { }); }, - readLabel: function(view, rI, cI, button, el, record) { - let me = this; - let drive = record.data.name; - - PBS.Utils.driveCommand(drive, 'read-label', { - waitMsgTarget: me.getView(), - success: PBS.Utils.showMediaLabelWindow, - }); - }, - - volumeStatistics: function(view, rI, cI, button, el, record) { - let me = this; - let drive = record.data.name; - PBS.Utils.driveCommand(drive, 'volume-statistics', { - waitMsgTarget: me.getView(), - success: PBS.Utils.showVolumeStatisticsWindow, - }); - }, - - cartridgeMemory: function(view, rI, cI, button, el, record) { - let me = this; - let drive = record.data.name; - PBS.Utils.driveCommand(drive, 'cartridge-memory', { - waitMsgTarget: me.getView(), - success: PBS.Utils.showCartridgeMemoryWindow, - }); - }, - reload: function() { this.getView().getStore().rstore.load(); }, @@ -193,33 +165,6 @@ Ext.define('PBS.TapeManagement.DrivePanel', { return record.data.changer ? value : ''; }, }, - { - text: gettext('Actions'), - width: 140, - xtype: 'actioncolumn', - items: [ - { - iconCls: 'fa fa-hdd-o', - handler: 'cartridgeMemory', - tooltip: gettext('Cartridge Memory'), - }, - { - iconCls: 'fa fa-line-chart', - handler: 'volumeStatistics', - tooltip: gettext('Volume Statistics'), - }, - { - iconCls: 'fa fa-tag', - handler: 'readLabel', - tooltip: gettext('Read Label'), - }, - { - iconCls: 'fa fa-info-circle', - handler: 'status', - tooltip: gettext('Status'), - }, - ], - }, ], }); diff --git a/www/tape/DriveStatus.js b/www/tape/DriveStatus.js index ec1b9fb9..284eb975 100644 --- a/www/tape/DriveStatus.js +++ b/www/tape/DriveStatus.js @@ -120,6 +120,27 @@ Ext.define('PBS.TapeManagement.DriveStatus', { }); }, + readLabel: function() { + let me = this; + let view = me.getView(); + let drive = view.drive; + + PBS.Utils.driveCommand(drive, 'read-label', { + waitMsgTarget: view, + success: PBS.Utils.showMediaLabelWindow, + }); + }, + + volumeStatistics: function() { + let me = this; + let view = me.getView(); + let drive = view.drive; + PBS.Utils.driveCommand(drive, 'volume-statistics', { + waitMsgTarget: view, + success: PBS.Utils.showVolumeStatisticsWindow, + }); + }, + init: function(view) { let me = this; me.mon(me.lookup('statusgrid').getStore().rstore, 'load', 'onLoad'); @@ -172,6 +193,27 @@ Ext.define('PBS.TapeManagement.DriveStatus', { disabled: '{!online}', }, }, + { + text: gettext('Read Label'), + xtype: 'proxmoxButton', + handler: 'readLabel', + iconCls: 'fa fa-tag', + disabled: true, + bind: { + disabled: '{!online}', + }, + }, + { + text: gettext('Show Volume Statistics'), + xtype: 'proxmoxButton', + handler: 'volumeStatistics', + iconCls: 'fa fa-line-chart', + disabled: true, + bind: { + disabled: '{!online}', + }, + }, + ], items: [ -- 2.20.1