From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B59D26969F for ; Tue, 2 Mar 2021 14:51:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8764F2D2DF for ; Tue, 2 Mar 2021 14:50:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1231D2D2D7 for ; Tue, 2 Mar 2021 14:50:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D35E044F7B for ; Tue, 2 Mar 2021 14:50:38 +0100 (CET) From: Dylan Whyte To: pbs-devel@lists.proxmox.com Date: Tue, 2 Mar 2021 14:50:19 +0100 Message-Id: <20210302135019.14433-1-d.whyte@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] Fix 3321: fix interactive restore command explanation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Mar 2021 13:51:09 -0000 The previous description in the docs was false. The restore command with the pattern parameter will search the entire backup archive, regardless of pwd. Signed-off-by: Dylan Whyte --- As a side note, the behaviour in the interactive shell still seems somewhat broken to me. In the case of this example, if you were to cd into etc and run the command with the pattern '**/*.conf', it would still search the entire archive rather than just /etc. Is this how it should be? docs/backup-client.rst | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/backup-client.rst b/docs/backup-client.rst index 384de958..598fd55d 100644 --- a/docs/backup-client.rst +++ b/docs/backup-client.rst @@ -460,16 +460,15 @@ subdirectory and add the corresponding pattern to the list for subsequent restor all files in the archive matching the patterns to ``/target/path`` on the local host. This will scan the whole archive. -With ``restore /target/path`` you can restore the sub-archive given by the current -working directory to the local target path ``/target/path`` on your host. -By additionally passing a glob pattern with ``--pattern ``, the restore is -further limited to files matching the pattern. -For example: +The ``restore`` command can be used to restore all the files contained within +the backup archive. This is most helpful when paired with the ``--pattern +`` option, as it allows you to restore all files matching a specific +pattern. For example, if you wanted to restore configuration files +located in ``/etc``, you could do the following: .. code-block:: console - pxar:/ > cd /etc/ - pxar:/etc/ > restore /target/ --pattern **/*.conf + pxar:/ > restore target/ --pattern etc/**/*.conf ... The above will scan trough all the directories below ``/etc`` and restore all -- 2.20.1