From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4EFD1695CF for ; Tue, 2 Mar 2021 12:20:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0B4012BAF7 for ; Tue, 2 Mar 2021 12:19:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B35C12BABD for ; Tue, 2 Mar 2021 12:19:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7375845850 for ; Tue, 2 Mar 2021 12:19:41 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 2 Mar 2021 12:19:40 +0100 Message-Id: <20210302111940.17276-5-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210302111940.17276-1-d.csapak@proxmox.com> References: <20210302111940.17276-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.201 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 5/5] ui: tape/DriveStatus: use the drive state to determine a status-load X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Mar 2021 11:20:13 -0000 since the status api call blocks the drive, it only makes sense to do when the drive is idle. so do not reload on activate, but when the drive changes the first time from busy to idle also disable the reload button when the drive is busy Signed-off-by: Dominik Csapak --- www/tape/DriveStatus.js | 42 +++++++++++++++++++++++++++++++++++++---- 1 file changed, 38 insertions(+), 4 deletions(-) diff --git a/www/tape/DriveStatus.js b/www/tape/DriveStatus.js index c9e9ea02..481f8b0d 100644 --- a/www/tape/DriveStatus.js +++ b/www/tape/DriveStatus.js @@ -18,6 +18,8 @@ Ext.define('PBS.TapeManagement.DriveStatus', { viewModel: { data: { online: false, + busy: true, + loaded: false, }, }, @@ -38,6 +40,33 @@ Ext.define('PBS.TapeManagement.DriveStatus', { vm.set('online', online); }, + onStateLoad: function(store) { + let me = this; + let view = me.getView(); + let vm = me.getViewModel(); + let driveRecord = store.findRecord('name', view.drive, 0, false, true, true); + let busy = !!driveRecord.data.state; + vm.set('busy', busy); + let statusgrid = me.lookup('statusgrid'); + if (!vm.get('loaded')) { + if (busy) { + // have to use a timeout so that the component can be rendered first + // otherwise the 'mask' call errors out + setTimeout(function() { + statusgrid.mask(gettext('Drive is busy')); + }, 10); + } else { + // have to use a timeout so that the component can be rendered first + // otherwise the 'mask' call errors out + setTimeout(function() { + statusgrid.unmask(); + }, 10); + me.reload(); + vm.set('loaded', true); + } + } + }, + labelMedia: function() { let me = this; Ext.create('PBS.TapeManagement.LabelMediaWindow', { @@ -84,18 +113,23 @@ Ext.define('PBS.TapeManagement.DriveStatus', { init: function(view) { let me = this; me.mon(me.lookup('statusgrid').getStore().rstore, 'load', 'onLoad'); + let tapeStore = Ext.ComponentQuery.query('navigationtree')[0].tapestore; + me.mon(tapeStore, 'load', 'onStateLoad'); + if (tapeStore.isLoaded()) { + me.onStateLoad(tapeStore); + } }, }, - listeners: { - activate: 'reload', - }, - tbar: [ { xtype: 'proxmoxButton', handler: 'reload', text: gettext('Reload'), + disabled: true, + bind: { + disabled: '{busy}', + }, }, '-', { -- 2.20.1