From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D79DD68EAB for ; Mon, 22 Feb 2021 14:25:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D52659E96 for ; Mon, 22 Feb 2021 14:25:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E01A09E86 for ; Mon, 22 Feb 2021 14:25:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AA47D46292 for ; Mon, 22 Feb 2021 14:25:38 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Mon, 22 Feb 2021 14:25:37 +0100 Message-Id: <20210222132537.7407-4-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210222132537.7407-1-d.csapak@proxmox.com> References: <20210222132537.7407-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.211 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 4/4] ui: tape/ChangerStatus: disable drive buttons when it's blocked X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2021 13:25:39 -0000 if the drive state is not empty, some action blocks it, so we cannot do any task anyway. Since we now refresh the state every 5 seconds, we can disable/enable them 'live'. Signed-off-by: Dominik Csapak --- www/tape/ChangerStatus.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js index 11b159ce..b1a294c4 100644 --- a/www/tape/ChangerStatus.js +++ b/www/tape/ChangerStatus.js @@ -795,35 +795,37 @@ Ext.define('PBS.TapeManagement.ChangerStatus', { iconCls: 'fa fa-rotate-270 fa-upload', handler: 'unload', tooltip: gettext('Unload'), - isDisabled: (v, r, c, i, rec) => !rec.data['label-text'], + isDisabled: (v, r, c, i, rec) => !rec.data['label-text'] || rec.data['is-blocked'], }, { iconCls: 'fa fa-hdd-o', handler: 'cartridgeMemory', tooltip: gettext('Cartridge Memory'), - isDisabled: (v, r, c, i, rec) => !rec.data['label-text'], + isDisabled: (v, r, c, i, rec) => !rec.data['label-text'] || rec.data['is-blocked'], }, { iconCls: 'fa fa-line-chart', handler: 'volumeStatistics', tooltip: gettext('Volume Statistics'), - isDisabled: (v, r, c, i, rec) => !rec.data['label-text'], + isDisabled: (v, r, c, i, rec) => !rec.data['label-text'] || rec.data['is-blocked'], }, { iconCls: 'fa fa-tag', handler: 'readLabel', tooltip: gettext('Read Label'), - isDisabled: (v, r, c, i, rec) => !rec.data['label-text'], + isDisabled: (v, r, c, i, rec) => !rec.data['label-text'] || rec.data['is-blocked'], }, { iconCls: 'fa fa-info-circle', tooltip: gettext('Status'), handler: 'status', + isDisabled: (v, r, c, i, rec) => rec.data['is-blocked'], }, { iconCls: 'fa fa-shower', tooltip: gettext('Clean Drive'), handler: 'cleanDrive', + isDisabled: (v, r, c, i, rec) => rec.data['is-blocked'], }, ], }, -- 2.20.1