From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 54D0B68E99 for ; Mon, 22 Feb 2021 14:26:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 520EB9E9C for ; Mon, 22 Feb 2021 14:25:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AD8189E76 for ; Mon, 22 Feb 2021 14:25:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 79C184628E for ; Mon, 22 Feb 2021 14:25:38 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Mon, 22 Feb 2021 14:25:34 +0100 Message-Id: <20210222132537.7407-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.210 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/4] ui: tape/ChangerStatus: only show loading on 'force refresh' X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2021 13:26:10 -0000 so that we can update in the background without interfering with the users workflow Signed-off-by: Dominik Csapak --- another alternative would be to have a 'spinning' loading icon at the top, but i think this is also ok, since the user explicitely pressed 'reload' www/tape/ChangerStatus.js | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js index bedeaaec..8e5ee900 100644 --- a/www/tape/ChangerStatus.js +++ b/www/tape/ChangerStatus.js @@ -413,8 +413,10 @@ Ext.define('PBS.TapeManagement.ChangerStatus', { } try { - Proxmox.Utils.setErrorMask(view, true); - Proxmox.Utils.setErrorMask(me.lookup('content')); + if (!use_cache) { + Proxmox.Utils.setErrorMask(view, true); + Proxmox.Utils.setErrorMask(me.lookup('content')); + } let status_fut = PBS.Async.api2({ timeout: 5*60*1000, method: 'GET', @@ -484,10 +486,15 @@ Ext.define('PBS.TapeManagement.ChangerStatus', { me.lookup('import_export').getStore().setData(data['import-export']); me.lookup('drives').getStore().setData(data.drive); - Proxmox.Utils.setErrorMask(view); + if (!use_cache) { + Proxmox.Utils.setErrorMask(view); + } + Proxmox.Utils.setErrorMask(me.lookup('content')); } catch (err) { - Proxmox.Utils.setErrorMask(view); - Proxmox.Utils.setErrorMask(me.lookup('content'), err); + if (!use_cache) { + Proxmox.Utils.setErrorMask(view); + } + Proxmox.Utils.setErrorMask(me.lookup('content'), err.toString()); } }, -- 2.20.1