From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9F95C6BB63 for ; Fri, 19 Feb 2021 15:40:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8EF9E1A4BF for ; Fri, 19 Feb 2021 15:40:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0435C1A4AF for ; Fri, 19 Feb 2021 15:40:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 96CE741A13 for ; Fri, 19 Feb 2021 15:40:24 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 19 Feb 2021 15:40:24 +0100 Message-Id: <20210219144024.10493-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210219144024.10493-1-d.csapak@proxmox.com> References: <20210219144024.10493-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.213 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/ChangerStatus: fixup for conditional X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 14:40:55 -0000 the statement !a === "somestring" cannot be true since !a is either true or false and thus not a string Signed-off-by: Dominik Csapak --- www/tape/ChangerStatus.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js index 5a1c6073..05ca8892 100644 --- a/www/tape/ChangerStatus.js +++ b/www/tape/ChangerStatus.js @@ -518,7 +518,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', { control: { 'grid[reference=drives]': { cellclick: function(table, td, ci, rec, tr, ri, e) { - if (!e.position.column.dataIndex === 'state') { + if (e.position.column.dataIndex !== 'state') { return; } -- 2.20.1