From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A79956B383 for ; Thu, 18 Feb 2021 13:47:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9C06FDCF4 for ; Thu, 18 Feb 2021 13:47:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 397E6DCEC for ; Thu, 18 Feb 2021 13:47:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 06F0641992 for ; Thu, 18 Feb 2021 13:47:47 +0100 (CET) From: Fabian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 18 Feb 2021 13:47:43 +0100 Message-Id: <20210218124743.6974-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH perlmod] array: avoid underflow when array is empty and more is zero X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2021 12:47:47 -0000 serializing an empty array triggered this. Signed-off-by: Fabian Ebner --- perlmod/src/array.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/perlmod/src/array.rs b/perlmod/src/array.rs index ce6e112..f0bce57 100644 --- a/perlmod/src/array.rs +++ b/perlmod/src/array.rs @@ -102,6 +102,7 @@ impl Array { /// Pre-extend the array to up to the specified length.. pub fn reserve(&self, more: usize) { + if more == 0 { return }; let idx = self.len() + more - 1; unsafe { ffi::RSPL_av_extend(self.av(), idx as libc::ssize_t); -- 2.20.1