From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id BADFB6A29C
for <pbs-devel@lists.proxmox.com>; Tue, 16 Feb 2021 09:35:28 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id B587211E07
for <pbs-devel@lists.proxmox.com>; Tue, 16 Feb 2021 09:35:28 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 530CE11DF8
for <pbs-devel@lists.proxmox.com>; Tue, 16 Feb 2021 09:35:27 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1775C419B6
for <pbs-devel@lists.proxmox.com>; Tue, 16 Feb 2021 09:35:27 +0100 (CET)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Tue, 16 Feb 2021 09:35:24 +0100
Message-Id: <20210216083526.16785-1-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.222 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [drive.rs]
Subject: [pbs-devel] [PATCH proxmox-backup 1/3] api2/tape/drive: add
optional label-text to erase
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 16 Feb 2021 08:35:28 -0000
if given, erases the tape only iff the inserted tape contains that label
used to safeguard tape erasing from ui for standalone drives
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/api2/tape/drive.rs | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/src/api2/tape/drive.rs b/src/api2/tape/drive.rs
index 4991d66b..12709df9 100644
--- a/src/api2/tape/drive.rs
+++ b/src/api2/tape/drive.rs
@@ -202,19 +202,23 @@ pub async fn unload(
optional: true,
default: true,
},
+ "label-text": {
+ schema: MEDIA_LABEL_SCHEMA,
+ optional: true,
+ },
},
},
returns: {
schema: UPID_SCHEMA,
},
)]
-/// Erase media
+/// Erase media. Check for label-text if given (cancels if wrong media).
pub fn erase_media(
drive: String,
fast: Option<bool>,
+ label_text: Option<String>,
rpcenv: &mut dyn RpcEnvironment,
) -> Result<Value, Error> {
-
let (config, _digest) = config::drive::config()?;
// early check/lock before starting worker
@@ -236,16 +240,32 @@ pub fn erase_media(
match drive.read_label() {
Err(err) => {
+ if let Some(label) = label_text {
+ bail!("expected label '{}', found unrelated data", label);
+ }
/* assume drive contains no or unrelated data */
task_log!(worker, "unable to read media label: {}", err);
task_log!(worker, "erase anyways");
drive.erase_media(fast.unwrap_or(true))?;
}
Ok((None, _)) => {
+ if let Some(label) = label_text {
+ bail!("expected label '{}', found empty tape", label);
+ }
task_log!(worker, "found empty media - erase anyways");
drive.erase_media(fast.unwrap_or(true))?;
}
Ok((Some(media_id), _key_config)) => {
+ if let Some(label_text) = label_text {
+ if media_id.label.label_text != label_text {
+ bail!(
+ "expected label '{}', found '{}', aborting",
+ label_text,
+ media_id.label.label_text
+ );
+ }
+ }
+
task_log!(
worker,
"found media '{}' with uuid '{}'",
--
2.20.1