From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 2037369FE8
for <pbs-devel@lists.proxmox.com>; Mon, 15 Feb 2021 15:22:55 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 16CCFBD61
for <pbs-devel@lists.proxmox.com>; Mon, 15 Feb 2021 15:22:25 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 7CBEBBD50
for <pbs-devel@lists.proxmox.com>; Mon, 15 Feb 2021 15:22:24 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B1EF4625A
for <pbs-devel@lists.proxmox.com>; Mon, 15 Feb 2021 15:22:24 +0100 (CET)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Mon, 15 Feb 2021 15:22:21 +0100
Message-Id: <20210215142223.11140-1-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.224 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] [PATCH proxmox-backup 1/3] ui: tape/TapeInventory:
change to regular store
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 15 Feb 2021 14:22:55 -0000
listing the media can potentially hang (changer status), so do not
reload in the background, only on activate
also increase the timeout to 5 minutes and add a reload button
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/TapeInventory.js | 28 ++++++++++------------------
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/www/tape/TapeInventory.js b/www/tape/TapeInventory.js
index 4bac4072..c641e492 100644
--- a/www/tape/TapeInventory.js
+++ b/www/tape/TapeInventory.js
@@ -18,6 +18,7 @@ Ext.define('pbs-model-tapes', {
proxy: {
type: 'proxmox',
url: '/api2/json/tape/media/list',
+ timeout: 5*60*1000,
},
});
@@ -71,35 +72,26 @@ Ext.define('PBS.TapeManagement.TapeInventory', {
},
reload: function() {
- this.getView().getStore().rstore.load();
- },
-
- stopStore: function() {
- this.getView().getStore().rstore.stopUpdate();
- },
-
- startStore: function() {
- this.getView().getStore().rstore.startUpdate();
+ this.getView().getStore().load();
},
},
listeners: {
- beforedestroy: 'stopStore',
- deactivate: 'stopStore',
- activate: 'startStore',
+ activate: 'reload',
},
store: {
- type: 'diff',
- rstore: {
- type: 'update',
- storeid: 'proxmox-tape-tapes',
- model: 'pbs-model-tapes',
- },
+ storeid: 'proxmox-tape-tapes',
+ model: 'pbs-model-tapes',
sorters: 'label-text',
},
tbar: [
+ {
+ text: gettext('Reload'),
+ handler: 'reload',
+ },
+ '-',
{
xtype: 'proxmoxButton',
text: gettext('Set Tape Location'),
--
2.20.1