From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EA08563266 for ; Tue, 9 Feb 2021 15:41:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E1E782EE7B for ; Tue, 9 Feb 2021 15:40:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 50AE72EE62 for ; Tue, 9 Feb 2021 15:40:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1AA3E45F8C for ; Tue, 9 Feb 2021 15:40:45 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 9 Feb 2021 15:40:42 +0100 Message-Id: <20210209144044.17782-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.229 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/3] ui: tape/BackupOverview: do not iterate over empty tapes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2021 14:41:16 -0000 tapes not belonging to a pool cannot contain data, so skip them Signed-off-by: Dominik Csapak --- www/tape/BackupOverview.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/tape/BackupOverview.js b/www/tape/BackupOverview.js index 6659d3ff..f4eb6654 100644 --- a/www/tape/BackupOverview.js +++ b/www/tape/BackupOverview.js @@ -46,6 +46,9 @@ Ext.define('PBS.TapeManagement.BackupOverview', { for (const entry of content_response.result.data) { let pool = entry.pool; + if (pool === undefined) { + continue; // pools not belonging to a pool cannot contain data + } let media_set = entry['media-set-name']; if (data[pool] === undefined) { data[pool] = {}; -- 2.20.1