From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 713BC6CB78 for ; Tue, 2 Feb 2021 14:00:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 530E5EE9B for ; Tue, 2 Feb 2021 14:00:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D3E7BEE68 for ; Tue, 2 Feb 2021 14:00:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 916914617D for ; Tue, 2 Feb 2021 14:00:40 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 2 Feb 2021 14:00:35 +0100 Message-Id: <20210202130039.6564-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210202130039.6564-1-d.csapak@proxmox.com> References: <20210202130039.6564-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.239 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 2/6] ui: refactor get_type_icon_cls X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2021 13:00:42 -0000 we need this later again Signed-off-by: Dominik Csapak --- www/Utils.js | 12 ++++++++++++ www/datastore/Content.js | 10 ++-------- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/www/Utils.js b/www/Utils.js index e6ea64ea..acfc4556 100644 --- a/www/Utils.js +++ b/www/Utils.js @@ -260,6 +260,18 @@ Ext.define('PBS.Utils', { return dedup; }, + get_type_icon_cls: function(btype) { + var cls = ''; + if (btype.startsWith('vm')) { + cls = 'fa-desktop'; + } else if (btype.startsWith('ct')) { + cls = 'fa-cube'; + } else if (btype.startsWith('host')) { + cls = 'fa-building'; + } + return cls; + }, + constructor: function() { var me = this; diff --git a/www/datastore/Content.js b/www/datastore/Content.js index 12dacb89..d0cf3e0b 100644 --- a/www/datastore/Content.js +++ b/www/datastore/Content.js @@ -105,14 +105,8 @@ Ext.define('PBS.DataStoreContent', { continue; } - var cls = ''; - if (btype === 'vm') { - cls = 'fa-desktop'; - } else if (btype === 'ct') { - cls = 'fa-cube'; - } else if (btype === 'host') { - cls = 'fa-building'; - } else { + var cls = PBS.Utils.get_type_icon_cls(btype); + if (cls === "") { console.warn(`got unknown backup-type '${btype}'`); continue; // FIXME: auto render? what do? } -- 2.20.1