From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 04B5D6BE7C for ; Thu, 28 Jan 2021 13:00:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 33F372D323 for ; Thu, 28 Jan 2021 13:00:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3573C2D245 for ; Thu, 28 Jan 2021 12:59:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E68114614C for ; Thu, 28 Jan 2021 12:59:57 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 28 Jan 2021 12:59:55 +0100 Message-Id: <20210128115955.23136-16-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210128115955.23136-1-d.csapak@proxmox.com> References: <20210128115955.23136-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.246 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [drive.rs] Subject: [pbs-devel] [PATCH proxmox-backup v2 15/15] tape: change changer-drive-id to changer-drivenum X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2021 12:00:05 -0000 because it changed in the config Signed-off-by: Dominik Csapak --- docs/tape-backup.rst | 8 ++++---- src/api2/config/drive.rs | 2 +- src/bin/proxmox_tape/drive.rs | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/tape-backup.rst b/docs/tape-backup.rst index 3c0bd2b6..c54eeed6 100644 --- a/docs/tape-backup.rst +++ b/docs/tape-backup.rst @@ -299,11 +299,11 @@ configuration entry:: If you have a tape library, you also need to set the associated changer device:: - # proxmox-tape drive update mydrive --changer sl3 --changer-drive-id 0 + # proxmox-tape drive update mydrive --changer sl3 --changer-drivenum 0 -The ``--changer-drive-id`` is only necessary if the tape library +The ``--changer-drivenum`` is only necessary if the tape library includes more than one drive (The changer status command lists all -drive IDs). +drivenums). You can show the final configuration with:: @@ -318,7 +318,7 @@ You can show the final configuration with:: │ changer │ sl3 │ └─────────┴────────────────────────────────┘ -.. NOTE:: The ``changer-drive-id`` value 0 is not stored in the +.. NOTE:: The ``changer-drivenum`` value 0 is not stored in the configuration, because that is the default. To list all configured drives use:: diff --git a/src/api2/config/drive.rs b/src/api2/config/drive.rs index 7d7803d3..8255d445 100644 --- a/src/api2/config/drive.rs +++ b/src/api2/config/drive.rs @@ -224,7 +224,7 @@ pub fn update_drive( data.changer_drivenum = None; } else { if data.changer.is_none() { - bail!("Option 'changer-drive-id' requires option 'changer'."); + bail!("Option 'changer-drivenum' requires option 'changer'."); } data.changer_drivenum = Some(changer_drivenum); } diff --git a/src/bin/proxmox_tape/drive.rs b/src/bin/proxmox_tape/drive.rs index e99ee860..da63f3a7 100644 --- a/src/bin/proxmox_tape/drive.rs +++ b/src/bin/proxmox_tape/drive.rs @@ -165,7 +165,7 @@ fn get_config( .column(ColumnConfig::new("name")) .column(ColumnConfig::new("path")) .column(ColumnConfig::new("changer")) - .column(ColumnConfig::new("changer-drive-id")) + .column(ColumnConfig::new("changer-drivenum")) ; format_and_print_result_full(&mut data, &info.returns, &output_format, &options); -- 2.20.1