From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0A7126B9F1 for ; Wed, 27 Jan 2021 11:56:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EB8142172E for ; Wed, 27 Jan 2021 11:55:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2B63421724 for ; Wed, 27 Jan 2021 11:55:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E30994468B for ; Wed, 27 Jan 2021 11:55:47 +0100 (CET) Date: Wed, 27 Jan 2021 11:55:45 +0100 From: Dominic =?iso-8859-1?Q?J=E4ger?= To: Proxmox Backup Server development discussion Message-ID: <20210127105545.GA8912@mala> References: <20210119110915.18864-1-d.jaeger@proxmox.com> <31f19138-bb58-1854-35f9-ef3023bb2c74@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31f19138-bb58-1854-35f9-ef3023bb2c74@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 0 AWL 1.692 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sencha.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2021 10:56:19 -0000 Thanks for looking at it! On Tue, Jan 26, 2021 at 11:34:54AM +0100, Dominik Csapak wrote: > when we have the error icon, we'd not need the asterisk, > since they both show the error We could theoretically show the asterisk without any color, just to symbolise "Required". But the error message shows this problem, too. So yes, it is redundant in some way. > or were they not intended to be applied together? It was intended to be applicable together, but only to easily show the possibilities together. Not because I absolutely want all of the patches to be applied. > also, the generic tooltip does always show on the whole > element for me, so with either the asterisk or the > icon, i still get multiple tooltips over one another Same for me. But the error message should appear only if you hover over the asterisk or the symbol. This means 1. if you hover over the error symbol, the error message is above the generic tooltip. Then you see what is wrong. 2. if you hover over the field, the error message vanishes and you see what you are supposed to enter into the field. Without msgTarget: side the error tooltip should also appear if you hover over the input field. Then you only see the generic tooltip when you hover over the label, which is a little less intuitive than 2., I think. > > another problem is with the detection of the 'required' > error. while this may work on english, extjs > errors are also translated, though i noticed we do > not do this yet for pbs (for pve we do) > so filtering by 'required' cannot work for other languages Makes sense, I missed that. > > and last but not least: > would it not be possible to show the tooltip just on the > label? > e.g.: > > --- > fieldLabel: `
${gettext('labeltext')}
' > --- I could not get this to work yet and I am not sure if it is possible? The "Remote" field has xtype pmxDisplayEditField > Ext.define('Proxmox.form.field.DisplayEdit', { > extend: 'Ext.form.FieldContainer', > alias: 'widget.pmxDisplayEditField', and then fieldLabel is just a String, no HTML? https://docs.sencha.com/extjs/6.0.1/classic/Ext.form.FieldContainer.html#cfg-fieldLabel > > a little bit less intuitive, but should not create overlapping > tooltips This means we would have the same messages visible as currently? 1. Generic tool while hovering over label 2. Error message else (= hovering over field) > > another alternative would be to add a displayfield below the > field with an explanation? Sounds good to me. Downside in comparison to tooltips would be limited amount of text for the hints? > > or simply add a screenshot with a list of fields to the documentation? List of fields + what belongs into them? Isn't that quite much work to look up "just" to fill out a field?