From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4870A6ADEF for ; Mon, 25 Jan 2021 11:52:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4111E8F91 for ; Mon, 25 Jan 2021 11:52:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BDBDC8F84 for ; Mon, 25 Jan 2021 11:52:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7DA2B440D2 for ; Mon, 25 Jan 2021 11:52:23 +0100 (CET) Date: Mon, 25 Jan 2021 11:52:22 +0100 From: Wolfgang Bumiller To: Fabian =?utf-8?Q?Gr=C3=BCnbichler?= Cc: pbs-devel@lists.proxmox.com Message-ID: <20210125105222.ley3xzq3kirpbkjv@olga.proxmox.com> References: <20210120162355.2750802-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210120162355.2750802-1-f.gruenbichler@proxmox.com> User-Agent: NeoMutt/20180716 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied series: [PATCH proxmox-backup 0/8] clippy fixes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2021 10:52:24 -0000 applied series On Wed, Jan 20, 2021 at 05:23:47PM +0100, Fabian Grünbichler wrote: > non-trivial clippy fixes and stuff I found while fixing clippy issues. > the remainder of warnings are now: > > - one derive_hash_xor_eq (Authid) > - one module_inception (rrd) > - one missing_safety_docs > - one wrong_self_convention (to_canonical_json not taking &self) > - plenty complex types, too many arguments and missing Default impl when > types have a fn new() without args > > which require individual attention to decide whether to refactor/fix, or > allow them. > > when writing new commits, the following should cut down on the noise > until all of the above are addressed: > > $ cargo clippy -- --allow clippy::type_complexity --allow clippy::new_without_default --allow clippy::too_many_arguments > > Fabian Grünbichler (8): > clippy: add is_empty() when len() is implemented > clippy: fix Mutex with unused value > clippy: rewrite comparison chains > clippy: rewrite ifs with identical return values > apt: let api handle optional bool with default > rework GC traversal error handling > http-client: fix typoed ticket cache condition > http-client: further clippy cleanups > > src/api2/access.rs | 32 +++++++++++++------------------- > src/api2/backup/environment.rs | 4 +++- > src/api2/node/apt.rs | 7 ++----- > src/api2/node/dns.rs | 2 +- > src/api2/node/tasks.rs | 16 ++++++---------- > src/backup/chunk_store.rs | 4 ++-- > src/backup/chunk_stream.rs | 7 ++----- > src/backup/datastore.rs | 18 ++++++++++-------- > src/client/http_client.rs | 10 +++++----- > src/config/network/parser.rs | 1 + > src/tools/acl.rs | 9 +++++++-- > src/tools/lru_cache.rs | 5 +++++ > 12 files changed, 57 insertions(+), 58 deletions(-) > > -- > 2.20.1