From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C3BA669E2D for ; Wed, 20 Jan 2021 17:24:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B7754AC40 for ; Wed, 20 Jan 2021 17:24:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9E76CAC34 for ; Wed, 20 Jan 2021 17:24:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6B79D4604B for ; Wed, 20 Jan 2021 17:24:19 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Wed, 20 Jan 2021 17:23:49 +0100 Message-Id: <20210120162355.2750802-3-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210120162355.2750802-1-f.gruenbichler@proxmox.com> References: <20210120162355.2750802-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [dns.rs, datastore.rs] Subject: [pbs-devel] [PATCH proxmox-backup 2/8] clippy: fix Mutex with unused value X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2021 16:24:50 -0000 Signed-off-by: Fabian Grünbichler --- src/api2/node/dns.rs | 2 +- src/backup/chunk_store.rs | 4 ++-- src/backup/datastore.rs | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/api2/node/dns.rs b/src/api2/node/dns.rs index 9a22bf60..e3dd614d 100644 --- a/src/api2/node/dns.rs +++ b/src/api2/node/dns.rs @@ -125,7 +125,7 @@ pub fn update_dns( ) -> Result { lazy_static! { - static ref MUTEX: Arc> = Arc::new(Mutex::new(0)); + static ref MUTEX: Arc> = Arc::new(Mutex::new(())); } let _guard = MUTEX.lock(); diff --git a/src/backup/chunk_store.rs b/src/backup/chunk_store.rs index f782169d..cc4a9435 100644 --- a/src/backup/chunk_store.rs +++ b/src/backup/chunk_store.rs @@ -18,7 +18,7 @@ pub struct ChunkStore { name: String, // used for error reporting pub (crate) base: PathBuf, chunk_dir: PathBuf, - mutex: Mutex, + mutex: Mutex<()>, locker: Arc>, } @@ -143,7 +143,7 @@ impl ChunkStore { base, chunk_dir, locker, - mutex: Mutex::new(false) + mutex: Mutex::new(()) }) } diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs index b1099460..34865380 100644 --- a/src/backup/datastore.rs +++ b/src/backup/datastore.rs @@ -37,7 +37,7 @@ lazy_static! { /// management interface for backup. pub struct DataStore { chunk_store: Arc, - gc_mutex: Mutex, + gc_mutex: Mutex<()>, last_gc_status: Mutex, verify_new: bool, } @@ -89,7 +89,7 @@ impl DataStore { Ok(Self { chunk_store: Arc::new(chunk_store), - gc_mutex: Mutex::new(false), + gc_mutex: Mutex::new(()), last_gc_status: Mutex::new(gc_status), verify_new: config.verify_new.unwrap_or(false), }) -- 2.20.1