From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 426B769E02 for ; Wed, 20 Jan 2021 17:24:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 354A5AC33 for ; Wed, 20 Jan 2021 17:24:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BFAF5AC29 for ; Wed, 20 Jan 2021 17:24:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8BC854604B for ; Wed, 20 Jan 2021 17:24:11 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Wed, 20 Jan 2021 17:23:48 +0100 Message-Id: <20210120162355.2750802-2-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210120162355.2750802-1-f.gruenbichler@proxmox.com> References: <20210120162355.2750802-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [acl.rs] Subject: [pbs-devel] [PATCH proxmox-backup 1/8] clippy: add is_empty() when len() is implemented X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2021 16:24:42 -0000 Signed-off-by: Fabian Grünbichler --- src/tools/acl.rs | 3 +++ src/tools/lru_cache.rs | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/src/tools/acl.rs b/src/tools/acl.rs index d9ae42a0..94f3f4df 100644 --- a/src/tools/acl.rs +++ b/src/tools/acl.rs @@ -322,6 +322,9 @@ impl ACLXAttrBuffer { self.buffer.len() } + /// The buffer always contains at least the version, it is never empty + pub const fn is_empty(&self) -> bool { false } + /// Borrow raw buffer as mut slice. pub fn as_mut_slice(&mut self) -> &mut [u8] { self.buffer.as_mut_slice() diff --git a/src/tools/lru_cache.rs b/src/tools/lru_cache.rs index 19012976..ecd15ba6 100644 --- a/src/tools/lru_cache.rs +++ b/src/tools/lru_cache.rs @@ -184,6 +184,11 @@ impl LruCache { self.map.len() } + /// Returns `true` when the cache is empty + pub fn is_empty(&self) -> bool { + self.map.is_empty() + } + /// Get a mutable reference to the value identified by `key`. /// This will update the cache entry to be the most recently used entry. /// On cache misses, the cachers fetch method is called to get a corresponding -- 2.20.1