From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B81C169D8B for ; Wed, 20 Jan 2021 17:24:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE002AC28 for ; Wed, 20 Jan 2021 17:24:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8A7A6AC1C for ; Wed, 20 Jan 2021 17:24:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4F6154604B for ; Wed, 20 Jan 2021 17:24:05 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Wed, 20 Jan 2021 17:23:47 +0100 Message-Id: <20210120162355.2750802-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [parser.rs, datastore.rs, tasks.rs, dns.rs, acl.rs, apt.rs, environment.rs, access.rs] Subject: [pbs-devel] [PATCH proxmox-backup 0/8] clippy fixes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2021 16:24:36 -0000 non-trivial clippy fixes and stuff I found while fixing clippy issues. the remainder of warnings are now: - one derive_hash_xor_eq (Authid) - one module_inception (rrd) - one missing_safety_docs - one wrong_self_convention (to_canonical_json not taking &self) - plenty complex types, too many arguments and missing Default impl when types have a fn new() without args which require individual attention to decide whether to refactor/fix, or allow them. when writing new commits, the following should cut down on the noise until all of the above are addressed: $ cargo clippy -- --allow clippy::type_complexity --allow clippy::new_without_default --allow clippy::too_many_arguments Fabian Grünbichler (8): clippy: add is_empty() when len() is implemented clippy: fix Mutex with unused value clippy: rewrite comparison chains clippy: rewrite ifs with identical return values apt: let api handle optional bool with default rework GC traversal error handling http-client: fix typoed ticket cache condition http-client: further clippy cleanups src/api2/access.rs | 32 +++++++++++++------------------- src/api2/backup/environment.rs | 4 +++- src/api2/node/apt.rs | 7 ++----- src/api2/node/dns.rs | 2 +- src/api2/node/tasks.rs | 16 ++++++---------- src/backup/chunk_store.rs | 4 ++-- src/backup/chunk_stream.rs | 7 ++----- src/backup/datastore.rs | 18 ++++++++++-------- src/client/http_client.rs | 10 +++++----- src/config/network/parser.rs | 1 + src/tools/acl.rs | 9 +++++++-- src/tools/lru_cache.rs | 5 +++++ 12 files changed, 57 insertions(+), 58 deletions(-) -- 2.20.1