From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8E28F69847 for ; Tue, 19 Jan 2021 14:35:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 75FAE1E569 for ; Tue, 19 Jan 2021 14:34:52 +0100 (CET) Received: from gaia.proxmox.com (212-186-127-178.static.upcbusiness.at [212.186.127.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 461BE1E55F for ; Tue, 19 Jan 2021 14:34:51 +0100 (CET) Received: from gaia.proxmox.com (localhost.localdomain [127.0.0.1]) by gaia.proxmox.com (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 10JDXNog1420263; Tue, 19 Jan 2021 14:33:23 +0100 Received: (from oguz@localhost) by gaia.proxmox.com (8.15.2/8.15.2/Submit) id 10JDXNV01420262; Tue, 19 Jan 2021 14:33:23 +0100 From: Oguz Bektas To: pbs-devel@lists.proxmox.com Date: Tue, 19 Jan 2021 14:33:23 +0100 Message-Id: <20210119133323.1420136-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.618 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.398 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pbs-devel] [PATCH proxmox-backup] ui: add missing uri encoding in user edit and view X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2021 13:35:22 -0000 userid parameter needs to be properly encoded when shown on the browser Signed-off-by: Oguz Bektas --- www/config/UserView.js | 2 ++ www/window/UserEdit.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/www/config/UserView.js b/www/config/UserView.js index 4645737a..ae313776 100644 --- a/www/config/UserView.js +++ b/www/config/UserView.js @@ -139,6 +139,8 @@ Ext.define('PBS.config.UserView', { xtype: 'proxmoxStdRemoveButton', baseurl: '/access/users/', enableFn: (rec) => rec.data.userid !== 'root@pam', + getUrl: (rec) => + `/access/users/${encodeURIComponent(rec.getId())}`, callback: 'reload', }, '-', diff --git a/www/window/UserEdit.js b/www/window/UserEdit.js index aaae835f..06ec5377 100644 --- a/www/window/UserEdit.js +++ b/www/window/UserEdit.js @@ -20,7 +20,7 @@ Ext.define('PBS.window.UserEdit', { var baseurl = '/api2/extjs/access/users'; me.isCreate = !userid; - me.url = userid ? baseurl + '/' + userid : baseurl; + me.url = userid ? baseurl + '/' + encodeURIComponent(userid) : baseurl; me.method = userid ? 'PUT' : 'POST'; me.autoLoad = !!userid; -- 2.20.1