From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0C30868E12 for ; Fri, 15 Jan 2021 11:49:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0355E23A5B for ; Fri, 15 Jan 2021 11:49:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 92A3323A51 for ; Fri, 15 Jan 2021 11:49:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5D49A44993 for ; Fri, 15 Jan 2021 11:49:13 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Fri, 15 Jan 2021 11:48:54 +0100 Message-Id: <20210115104855.3992674-2-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210115104855.3992674-1-f.gruenbichler@proxmox.com> References: <20210115104855.3992674-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pull.rs] Subject: [pbs-devel] [PATCH proxmox-backup 2/3] pull: add error context for initial group list call X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2021 10:49:44 -0000 otherwise the user is confronted with a generic error like "permission check failed" with no indication that it refers to a request made to the remote PBS instance.. Signed-off-by: Fabian Grünbichler --- src/client/pull.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/client/pull.rs b/src/client/pull.rs index f6ef7cde..15514374 100644 --- a/src/client/pull.rs +++ b/src/client/pull.rs @@ -570,7 +570,10 @@ pub async fn pull_store( let path = format!("api2/json/admin/datastore/{}/groups", src_repo.store()); - let mut result = client.get(&path, None).await?; + let mut result = client + .get(&path, None) + .await + .map_err(|err| format_err!("Failed to retrieve backup groups from remote - {}", err))?; let mut list: Vec = serde_json::from_value(result["data"].take())?; -- 2.20.1