From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DA65C679EC for ; Wed, 13 Jan 2021 12:07:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B7FD0101D6 for ; Wed, 13 Jan 2021 12:06:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 51944101A9 for ; Wed, 13 Jan 2021 12:06:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1C91245E17 for ; Wed, 13 Jan 2021 12:06:55 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Wed, 13 Jan 2021 12:06:48 +0100 Message-Id: <20210113110654.17425-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.271 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 0/6] tfa fixups X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2021 11:07:26 -0000 fixed some of the more weird spacing/style issues i saw there are still some issues, but maybe someone else can look at it: * there is no gui for initial webauthn setup (which is mandatory) * The text 'Copy Secret Value' is weird, but i could not come up with something better for now * on login, the text should not be 'OTP' for recovery keys, it should be distinct, else it is very confusing * the spacing on the login windows and deletion confirm window is still wrong * the deletion confirm window has the title 'Confirm Password', but as root@pam, there is no password field (better only "Conifrm"?) we maybe can reuse our 'Safe Destroy Window' here? * when i enter a wrong password, the error message is AUTH_ERR (7) which is not informational, and not consistent with our login. * Some edit/add windows can be refactored using the Edit Window, currently the functionality is duplicated across them (addWebauthn, addTotp, etc.) * The warning that there are only few recovery codes left has too many warning icons (one should be enough) * Sometimes i ran into an issue, where, if i have the recovery login window open for too long, the code is not accepted. It was not very clear to me if i can reuse that code again (i could) but that seems to be bad ux, since normally a recovery code is not something i have on hand, and it'll take a while until i found one. Dominik Csapak (6): ui: LoginView: remove not used viewModel ui: config/TfaView: disable Remove button by default ui: window/AddTfaRecovery: rewrite to a Proxmox.window.Edit ui: window/AddTfaRecovery: fix style of TfaRecoveryShow window ui: window/AddTotp: fix spacing styling of form fields ui: window/{AddWebauthn,TfaEdit}: fix spacing/border of the windows www/LoginView.js | 8 --- www/config/TfaView.js | 1 + www/window/AddTfaRecovery.js | 136 ++++++++++++----------------------- www/window/AddTotp.js | 81 ++++++++++----------- www/window/AddWebauthn.js | 2 +- www/window/TfaEdit.js | 1 - 6 files changed, 86 insertions(+), 143 deletions(-) -- 2.20.1