From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A3809677C7 for ; Tue, 12 Jan 2021 15:41:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9B1058B3D for ; Tue, 12 Jan 2021 15:41:29 +0100 (CET) Received: from gaia.proxmox.com (212-186-127-178.static.upcbusiness.at [212.186.127.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2A7C08B30 for ; Tue, 12 Jan 2021 15:41:29 +0100 (CET) Received: from gaia.proxmox.com (localhost.localdomain [127.0.0.1]) by gaia.proxmox.com (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 10CEe9rw931611; Tue, 12 Jan 2021 15:40:09 +0100 Received: (from oguz@localhost) by gaia.proxmox.com (8.15.2/8.15.2/Submit) id 10CEe9hv931610; Tue, 12 Jan 2021 15:40:09 +0100 From: Oguz Bektas To: pbs-devel@lists.proxmox.com Date: Tue, 12 Jan 2021 15:40:06 +0100 Message-Id: <20210112144006.931307-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.667 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.398 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [user.rs] Subject: [pbs-devel] [PATCH proxmox-backup] access: limit editing pam credentials to superuser X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2021 14:41:29 -0000 modifying @pam users' credentials should be only allowed for root@pam, otherwise it can have unintended consequences. Signed-off-by: Oguz Bektas --- src/api2/access/user.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/api2/access/user.rs b/src/api2/access/user.rs index 484919bf..7c19db2f 100644 --- a/src/api2/access/user.rs +++ b/src/api2/access/user.rs @@ -350,8 +350,11 @@ pub fn update_user( email: Option, delete: Option>, digest: Option, + rpcenv: &mut dyn RpcEnvironment, ) -> Result<(), Error> { + let user_info = CachedUserInfo::new()?; + let _lock = open_file_locked(user::USER_CFG_LOCKFILE, std::time::Duration::new(10, 0), true)?; let (mut config, expected_digest) = user::config()?; @@ -391,8 +394,13 @@ pub fn update_user( data.expire = if expire > 0 { Some(expire) } else { None }; } + if let Some(password) = password { + let source_auth_id = rpcenv.get_auth_id().unwrap().parse()?; let authenticator = crate::auth::lookup_authenticator(userid.realm())?; + if userid.realm() == "pam" && !user_info.is_superuser(&source_auth_id) { + bail!("only superuser can edit this!"); + } authenticator.store_password(userid.name(), &password)?; } -- 2.20.1