From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 59C9967298 for ; Tue, 12 Jan 2021 10:21:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 51D9022391 for ; Tue, 12 Jan 2021 10:21:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D4C2122389 for ; Tue, 12 Jan 2021 10:21:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A866844818 for ; Tue, 12 Jan 2021 10:21:17 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 12 Jan 2021 10:21:17 +0100 Message-Id: <20210112092117.22444-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.273 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] fix #3245: only use default schedule for new jobs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2021 09:21:48 -0000 an empty schedule means 'none', so do not fill it with the default in case we edit an existing job (like we do already for sync jobs) Signed-off-by: Dominik Csapak --- www/window/VerifyJobEdit.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/window/VerifyJobEdit.js b/www/window/VerifyJobEdit.js index 2a22e3d6..40db207d 100644 --- a/www/window/VerifyJobEdit.js +++ b/www/window/VerifyJobEdit.js @@ -23,6 +23,7 @@ Ext.define('PBS.window.VerifyJobEdit', { me.isCreate = !id; me.url = id ? `${baseurl}/${id}` : baseurl; me.method = id ? 'PUT' : 'POST'; + me.scheduleValue = id ? null : 'daily'; me.autoLoad = !!id; me.editDatastore = me.datastore === undefined && me.isCreate; return { }; @@ -64,8 +65,8 @@ Ext.define('PBS.window.VerifyJobEdit', { name: 'schedule', fieldLabel: gettext('Schedule'), emptyText: gettext('none (disabled)'), - value: 'daily', cbind: { + value: '{scheduleValue}', deleteEmpty: '{!isCreate}', }, }, -- 2.20.1