From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1059661974 for ; Mon, 30 Nov 2020 16:23:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0711B17E33 for ; Mon, 30 Nov 2020 16:22:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 93EF917E29 for ; Mon, 30 Nov 2020 16:22:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5CAB84439D for ; Mon, 30 Nov 2020 16:22:54 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Mon, 30 Nov 2020 16:22:20 +0100 Message-Id: <20201130152220.658777-5-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201130152220.658777-1-f.gruenbichler@proxmox.com> References: <20201130152220.658777-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [RFC proxmox-backup 4/4] gc: don't limit index listing to same filesystem X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 15:23:25 -0000 WalkDir does not follow symlinks by default anyway, and this behaviour is not documented anywhere. e.g., if a sysadmin mounts 'extra storage' for some backup group or type (not knowing that only metadata is stored in those directories), GC will ignore all the indices contained within and happily garbage collect their chunks.. Signed-off-by: Fabian Grünbichler --- Notes: RFC since I am not 100% sure, but the current behaviour seems like a timebomb waiting to bite someone's behind.. src/backup/datastore.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs index 8ea0a753..a4c437e1 100644 --- a/src/backup/datastore.rs +++ b/src/backup/datastore.rs @@ -380,7 +380,7 @@ impl DataStore { use walkdir::WalkDir; - let walker = WalkDir::new(&base).same_file_system(true).into_iter(); + let walker = WalkDir::new(&base).into_iter(); // make sure we skip .chunks (and other hidden files to keep it simple) fn is_hidden(entry: &walkdir::DirEntry) -> bool { -- 2.20.1