From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1036A63D23 for ; Wed, 25 Nov 2020 14:29:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 043DF1A8A4 for ; Wed, 25 Nov 2020 14:29:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D248A1A897 for ; Wed, 25 Nov 2020 14:29:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 93E0D43B36 for ; Wed, 25 Nov 2020 14:29:04 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Wed, 25 Nov 2020 14:28:51 +0100 Message-Id: <20201125132851.2659108-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-client.rs] Subject: [pbs-devel] [PATCH proxmox-backup] restore: print to STDERR X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2020 13:29:06 -0000 else restoring to STDOUT is broken.. Reported-by: Dominic Jäger Signed-off-by: Fabian Grünbichler --- src/bin/proxmox-backup-client.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/bin/proxmox-backup-client.rs b/src/bin/proxmox-backup-client.rs index 80b1ff22..372ff268 100644 --- a/src/bin/proxmox-backup-client.rs +++ b/src/bin/proxmox-backup-client.rs @@ -644,7 +644,7 @@ fn keyfile_parameters(param: &Value) -> Result<(Option>, CryptMode), Err (None, None) => None, (Some(_), Some(_)) => bail!("--keyfile and --keyfd are mutually exclusive"), (Some(keyfile), None) => { - println!("Using encryption key file: {}", keyfile); + eprintln!("Using encryption key file: {}", keyfile); Some(file_get_contents(keyfile)?) }, (None, Some(fd)) => { @@ -654,7 +654,7 @@ fn keyfile_parameters(param: &Value) -> Result<(Option>, CryptMode), Err .map_err(|err| { format_err!("error reading encryption key from fd {}: {}", fd, err) })?; - println!("Using encryption key from file descriptor"); + eprintln!("Using encryption key from file descriptor"); Some(data) } }; @@ -663,7 +663,7 @@ fn keyfile_parameters(param: &Value) -> Result<(Option>, CryptMode), Err // no parameters: (None, None) => match key::read_optional_default_encryption_key()? { Some(key) => { - println!("Encrypting with default encryption key!"); + eprintln!("Encrypting with default encryption key!"); (Some(key), CryptMode::Encrypt) }, None => (None, CryptMode::None), @@ -676,7 +676,7 @@ fn keyfile_parameters(param: &Value) -> Result<(Option>, CryptMode), Err (None, Some(crypt_mode)) => match key::read_optional_default_encryption_key()? { None => bail!("--crypt-mode without --keyfile and no default key file available"), Some(key) => { - println!("Encrypting with default encryption key!"); + eprintln!("Encrypting with default encryption key!"); (Some(key), crypt_mode) }, } @@ -1257,7 +1257,7 @@ async fn restore(param: Value) -> Result { None => None, Some(key) => { let (key, _, fingerprint) = decrypt_key(&key, &key::get_encryption_key_password)?; - println!("Encryption key fingerprint: '{}'", fingerprint); + eprintln!("Encryption key fingerprint: '{}'", fingerprint); Some(Arc::new(CryptConfig::new(key)?)) } }; -- 2.20.1